903143 - foreign text characters don't have replacement in remix URL

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Jacob [:Jacob]]

Not sure if this is an issue or not, but pointing out the observation that because this make has japanese characters in the title, the URL didn't have anything to fill in so it's blank. like this

https://a.makes.org/thimble/remix-of-

If he did multiple remixes in Thimble and wanted a Japanese title, there would be a problem because the URL would be the same right?

Comment 1

[Jon Buckley [:jbuck]]

https://github.com/jeremys/uslug/ looks good

Comment 2

[Pomax]

unassigning pending reprioritisation

Comment 3

[Elsi [:elnushaj]]

Could I get some more details on what this task requires?

Comment 5

[Jon Buckley [:jbuck]]

Sure! Basically, you'll need to replace the slugify function in https://github.com/mozilla/thimble.webmaker.org/blob/master/lib/utils.js with something that handles unicode better. uslug is just one such example

Comment 6

[Elsi [:elnushaj]]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/310

Comment 7

[Pomax]

Comment on attachment 8341583 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/310

this wasn't rebased on the latest mozilla master, so it can't be merged in yet. If you can update your master to the latest mozilla master, and then redo the rebase, it should be fine.

Comment 8

[Pomax]

Comment on attachment 8341583 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/310

some notes in the PR

Comment 9

[Pomax]

Comment on attachment 8341583 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/310

This also probably needs some tests somewhere, so that we can prove it does what we want it to.

Comment 10

[Pomax]

Comment on attachment 8341583 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/310

good start, the test can get merge in with the reintroduction of friendlycode and slowparse unit testing. Thanks.