Closed
Bug 903143
Opened 11 years ago
Closed 9 years ago
foreign text characters don't have replacement in remix URL
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Jacob, Assigned: elnushaj)
References
Details
Attachments
(1 file)
Not sure if this is an issue or not, but pointing out the observation that because this make has japanese characters in the title, the URL didn't have anything to fill in so it's blank. like this https://a.makes.org/thimble/remix-of- If he did multiple remixes in Thimble and wanted a Japanese title, there would be a problem because the URL would be the same right?
Comment 1•11 years ago
|
||
https://github.com/jeremys/uslug/ looks good
Assignee | ||
Comment 3•11 years ago
|
||
Could I get some more details on what this task requires?
Flags: needinfo?
Comment 5•11 years ago
|
||
Sure! Basically, you'll need to replace the slugify function in https://github.com/mozilla/thimble.webmaker.org/blob/master/lib/utils.js with something that handles unicode better. uslug is just one such example
Updated•11 years ago
|
Assignee: nobody → enushaj
Status: NEW → ASSIGNED
Flags: needinfo?
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #8341583 -
Flags: review?(pomax)
Comment on attachment 8341583 [details] https://github.com/mozilla/thimble.webmaker.org/pull/310 this wasn't rebased on the latest mozilla master, so it can't be merged in yet. If you can update your master to the latest mozilla master, and then redo the rebase, it should be fine.
Attachment #8341583 -
Flags: review?(pomax) → review-
Assignee | ||
Updated•11 years ago
|
Attachment #8341583 -
Flags: review- → review?
Assignee | ||
Updated•11 years ago
|
Attachment #8341583 -
Flags: review? → review?(pomax)
Comment on attachment 8341583 [details] https://github.com/mozilla/thimble.webmaker.org/pull/310 some notes in the PR
Attachment #8341583 -
Flags: review?(pomax) → review-
Comment on attachment 8341583 [details] https://github.com/mozilla/thimble.webmaker.org/pull/310 This also probably needs some tests somewhere, so that we can prove it does what we want it to.
Assignee | ||
Updated•11 years ago
|
Attachment #8341583 -
Flags: review- → review?(pomax)
Attachment #8341583 -
Attachment description: https://github.com/mozilla/thimble.webmaker.org/pull/310/files → https://github.com/mozilla/thimble.webmaker.org/pull/310
Attachment #8341583 -
Attachment filename: file_903143.txt → 310
Comment 10•11 years ago
|
||
Comment on attachment 8341583 [details] https://github.com/mozilla/thimble.webmaker.org/pull/310 good start, the test can get merge in with the reintroduction of friendlycode and slowparse unit testing. Thanks.
Attachment #8341583 -
Flags: review?(pomax) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•