903178 - [MP] Defect - Start screen should scroll vertically when in portrait mode

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

Description

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: WIP

Right now we get a lot of empty space at the bottom of the start screen when in portrait mode. We should stack the tile groups vertically.

I'm attaching a WIP patch that gets us almost there, the only thing missing is getting the right number of columns in grid arrangeItems - i.e. we need to get the right containerDims.width.

Comment 1

[Marco Mucci [:MarcoM]]

p=1 from Rodrigo for future placement.

Comment 2

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: WIP v2

WIP v2 after StartUI moved to a browser.

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

I tried playing with column-count and column-fill but had no success, so kept the calculation in grid.xml.

I'm also removing a double call to arrengeItem that was happening when showing the startUI. I can move that to another patch/bug if needed.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 793122 [details] [diff] [review]
Patch v1

Review of attachment 793122 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, works well. Clean test run even!

Comment 5

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/fx-team/rev/606d259eafe9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/606d259eafe9