[MP] Defect - Start screen should scroll vertically when in portrait mode

RESOLVED FIXED in Firefox 26

Status

P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: rsilveira, Assigned: rsilveira)

Tracking

Trunk
Firefox 26
x86_64
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [preview] feature=defect c=tbd u=tbd p=3)

Attachments

(1 attachment, 2 obsolete attachments)

Created attachment 787819 [details] [diff] [review]
WIP

Right now we get a lot of empty space at the bottom of the start screen when in portrait mode. We should stack the tile groups vertically.

I'm attaching a WIP patch that gets us almost there, the only thing missing is getting the right number of columns in grid arrangeItems - i.e. we need to get the right containerDims.width.
p=1 from Rodrigo for future placement.
Blocks: 859003
Summary: Start screen should scroll vertically when in portrait mode → Defect - Start screen should scroll vertically when in portrait mode
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0

Updated

5 years ago
Blocks: 838081
No longer blocks: 859003

Updated

5 years ago
Blocks: 899390
Summary: Defect - Start screen should scroll vertically when in portrait mode → [MP] Defect - Start screen should scroll vertically when in portrait mode
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=0
(Assignee)

Updated

5 years ago
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=3

Updated

5 years ago
Blocks: 898799
No longer blocks: 838081
Priority: -- → P2
Created attachment 791450 [details] [diff] [review]
WIP v2

WIP v2 after StartUI moved to a browser.
Attachment #787819 - Attachment is obsolete: true
Created attachment 793122 [details] [diff] [review]
Patch v1

I tried playing with column-count and column-fill but had no success, so kept the calculation in grid.xml.

I'm also removing a double call to arrengeItem that was happening when showing the startUI. I can move that to another patch/bug if needed.
Attachment #791450 - Attachment is obsolete: true
Attachment #793122 - Flags: review?(sfoster)

Updated

5 years ago
QA Contact: jbecerra
Comment on attachment 793122 [details] [diff] [review]
Patch v1

Review of attachment 793122 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, works well. Clean test run even!
Attachment #793122 - Flags: review?(sfoster) → review+
(Assignee)

Updated

5 years ago
Blocks: 907935
https://hg.mozilla.org/mozilla-central/rev/606d259eafe9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.