Closed Bug 903178 Opened 7 years ago Closed 7 years ago

[MP] Defect - Start screen should scroll vertically when in portrait mode

Categories

(Firefox for Metro Graveyard :: Firefox Start, defect, P2)

x86_64
Windows 8.1
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: rsilveira, Assigned: rsilveira)

References

Details

(Whiteboard: [preview] feature=defect c=tbd u=tbd p=3)

Attachments

(1 file, 2 obsolete files)

Attached patch WIP (obsolete) — Splinter Review
Right now we get a lot of empty space at the bottom of the start screen when in portrait mode. We should stack the tile groups vertically.

I'm attaching a WIP patch that gets us almost there, the only thing missing is getting the right number of columns in grid arrangeItems - i.e. we need to get the right containerDims.width.
p=1 from Rodrigo for future placement.
Summary: Start screen should scroll vertically when in portrait mode → Defect - Start screen should scroll vertically when in portrait mode
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0
Blocks: metrov1backlog
No longer blocks: metrov1defect&change
Summary: Defect - Start screen should scroll vertically when in portrait mode → [MP] Defect - Start screen should scroll vertically when in portrait mode
Whiteboard: [preview-triage] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=0
Assignee: nobody → rsilveira
Status: NEW → ASSIGNED
Whiteboard: [preview] feature=defect c=tbd u=tbd p=0 → [preview] feature=defect c=tbd u=tbd p=3
Blocks: metrov1it13
No longer blocks: metrov1backlog
Priority: -- → P2
Attached patch WIP v2 (obsolete) — Splinter Review
WIP v2 after StartUI moved to a browser.
Attachment #787819 - Attachment is obsolete: true
Attached patch Patch v1Splinter Review
I tried playing with column-count and column-fill but had no success, so kept the calculation in grid.xml.

I'm also removing a double call to arrengeItem that was happening when showing the startUI. I can move that to another patch/bug if needed.
Attachment #791450 - Attachment is obsolete: true
Attachment #793122 - Flags: review?(sfoster)
QA Contact: jbecerra
Comment on attachment 793122 [details] [diff] [review]
Patch v1

Review of attachment 793122 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, works well. Clean test run even!
Attachment #793122 - Flags: review?(sfoster) → review+
Blocks: 907935
https://hg.mozilla.org/mozilla-central/rev/606d259eafe9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.