903230 - D3D9SurfaceImage.h exported twice

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

It's in gfx/layers/moz.build twice, in EXPORTS.mozilla.layers and EXPORTS.  Where does it belong?

Comment 1

[(no longer active)]

Should we fail the build if somebody does this?

Comment 2

[Gregory Szorc [:gps]]

If there is only a single output path, it should only be specified once globally, in the closest moz.build file in the directory structure.

Once bug 896797 lands, duplicate definitions like this will likely result in a fatal error.

If you find other issues where you think moz.build files aren't being strict enough, please file bugs! We want to catch build errors early in the build so users don't have to sit through 30 minutes of compiling only to find out the build config is bad.