Closed
Bug 903236
Opened 12 years ago
Closed 12 years ago
[MarionetteJS] Test to verify part of today's date on agenda view on month view
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: jsmith, Assigned: jsmith)
Details
Attachments
(1 file)
Write a simple MarionetteJS test to verify part of today's date on the agenda view on the month view.
| Assignee | ||
Updated•12 years ago
|
Assignee: nobody → jsmith
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•12 years ago
|
||
| Assignee | ||
Comment 2•12 years ago
|
||
Comment on attachment 788241 [details]
Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/11463
Probably need to clean some of this up, but putting feedback at least to get a first impression if this is on the right track.
Attachment #788241 -
Flags: feedback?(jlal)
Comment 3•12 years ago
|
||
Comment on attachment 788241 [details]
Pointer to Github Pull Request: https://github.com/mozilla-b2g/gaia/pull/11463
I am going to un-mark feedback here (since we are kinda by proxy talking about test design in Gareth's PR).
Essentially the small test in here makes sense as is but we would need to account for some additional things for this to land:
1- Time on "host" right now b2g-desktop is always the time as the test running the marionette commands so life is good. Once we run on emulators/phones this may break. To solve portability issues we should fetch the current time from the "host" (using the client) and create a date object based on that.
2- I would like to use the new logic we are defining in Gareth's PR (some abstractions) for launching the app / finding elements.
Once Gareth's path lands (or you base your work on his) I would like to land this / put in official review.
Attachment #788241 -
Flags: feedback?(jlal)
| Assignee | ||
Comment 4•12 years ago
|
||
No longer a valid test per recent changes to remove the today date from the calendar month view.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
No longer depends on: 906821
Resolution: --- → INVALID
| Assignee | ||
Comment 5•12 years ago
|
||
Disregard - I'm not right here.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
| Assignee | ||
Comment 6•12 years ago
|
||
Actually, I'm closing this out since we're making an effort to not duplicate tests between gaia ui tests and marionette js. Gaia ui tests technically already covers this, so no need to duplicate.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•