Closed Bug 903283 Opened 6 years ago Closed 6 years ago

Remove some includes of EventTarget.h

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Comment on attachment 787966 [details] [diff] [review]
Don't include EventTarget.h in headers r=Ms2ger

Review of attachment 787966 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/Touch.cpp
@@ +116,5 @@
>    mPointsInitialized = true;
>  }
>  
> +void
> +Touch::SetTarget(mozilla::dom::EventTarget *aTarget)

* to the left

::: content/events/src/Touch.h
@@ +48,5 @@
>    NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(Touch)
>  
>    void InitializePoints(nsPresContext* aPresContext, nsEvent* aEvent);
>  
> +  void SetTarget(mozilla::dom::EventTarget *aTarget);

* to the left

::: content/events/src/nsDOMEvent.h
@@ +18,1 @@
>  #include "mozilla/dom/EventBinding.h"

Would be interesting to see if we can get rid of those too...

::: widget/nsGUIEvent.h
@@ -7,5 @@
>  #define nsGUIEvent_h__
>  
>  #include "mozilla/MathAlgorithms.h"
>  
> -#include "nsCOMArray.h"

Those aren't EventTargets anymore ;)
Attachment #787966 - Flags: review?(Ms2ger) → review+
https://hg.mozilla.org/mozilla-central/rev/d608711909f4
Assignee: nobody → dzbarsky
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Hmm, what was checked in isn't what was reviewed here. At least it's a lot more - didn't check in detail.

The (unreviewed) changes to nsWidget.h seem to have broken external api builds. I think, re-compiling now.
How are they broken?
If it's build errors with strings, we probably need to include nsStringGlue.h in nsIWidget.h.
Does reverting that fix the build?
Still compiling... i'll let you know once it's done. (Full rebuild, so this will take some time.)
Yes, with this external api builds again.
Attachment #794175 - Flags: review?(Ms2ger)
Comment on attachment 794175 [details] [diff] [review]
bug903283_external_api_fix.patch

Review of attachment 794175 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #794175 - Flags: review?(Ms2ger) → review+
Keywords: checkin-needed
Whiteboard: [leave closed] → [leave closed][checkin-needed for bug903283_external_api_fix.patch]
(In reply to neil@parkwaycc.co.uk from comment #14)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/7a51e8137c01
Keywords: checkin-needed
Whiteboard: [leave closed][checkin-needed for bug903283_external_api_fix.patch] → [leave closed]
https://hg.mozilla.org/mozilla-central/rev/7a51e8137c01

Note that this landed with bug 903284 in the commit message.
Whiteboard: [leave closed]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.