903283 - Remove some includes of EventTarget.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Don't include EventTarget.h in headers r=Ms2ger

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 787966 [details] [diff] [review]
Don't include EventTarget.h in headers r=Ms2ger

Review of attachment 787966 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/Touch.cpp
@@ +116,5 @@
>    mPointsInitialized = true;
>  }
>  
> +void
> +Touch::SetTarget(mozilla::dom::EventTarget *aTarget)

* to the left

::: content/events/src/Touch.h
@@ +48,5 @@
>    NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(Touch)
>  
>    void InitializePoints(nsPresContext* aPresContext, nsEvent* aEvent);
>  
> +  void SetTarget(mozilla::dom::EventTarget *aTarget);

* to the left

::: content/events/src/nsDOMEvent.h
@@ +18,1 @@
>  #include "mozilla/dom/EventBinding.h"

Would be interesting to see if we can get rid of those too...

::: widget/nsGUIEvent.h
@@ -7,5 @@
>  #define nsGUIEvent_h__
>  
>  #include "mozilla/MathAlgorithms.h"
>  
> -#include "nsCOMArray.h"

Those aren't EventTargets anymore ;)

Comment 3

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea0f2d537a40

Comment 4

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d608711909f4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d608711909f4

Comment 6

[Magnus Melin [:mkmelin]]

Hmm, what was checked in isn't what was reviewed here. At least it's a lot more - didn't check in detail.

The (unreviewed) changes to nsWidget.h seem to have broken external api builds. I think, re-compiling now.

Comment 7

[David Zbarsky (:dzbarsky)]

How are they broken?

Comment 8

[David Zbarsky (:dzbarsky)]

If it's build errors with strings, we probably need to include nsStringGlue.h in nsIWidget.h.

Comment 9

[Magnus Melin [:mkmelin]]

Yes - https://hg.mozilla.org/mozilla-central/diff/d608711909f4/widget/nsIWidget.h

Comment 10

[David Zbarsky (:dzbarsky)]

Does reverting that fix the build?

Comment 11

[Magnus Melin [:mkmelin]]

Still compiling... i'll let you know once it's done. (Full rebuild, so this will take some time.)

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: bug903283_external_api_fix.patch

Yes, with this external api builds again.

Comment 13

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 794175 [details] [diff] [review]
bug903283_external_api_fix.patch

Review of attachment 794175 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 14

[[e-mail]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a51e8137c01

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to [e-mail] from comment #14)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/7a51e8137c01

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7a51e8137c01

Note that this landed with bug 903284 in the commit message.