Closed Bug 903337 Opened 11 years ago Closed 11 years ago

Do not display the CC list and the "Remove selected CCs" checkbox if the CC list is empty

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

Product:
Bugzilla
Component:
Creating/Changing Bugs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.4

People

(Reporter: sjoshi, Assigned: sjoshi)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

Patch-v3
2.71 KB, patch
mail
: review+
Details | Diff | Splinter Review
Attached patch Patch-v1 (obsolete) — — Splinter Review 
Open a bug that doesnot have a CC list, 
CC List:	 Add me to CC list 
0 users (edit)
click on edit 

It displays an empty CC list box and Checkbox "Remove selected CCs"

Expected Result:
It should display CC list box and Checkbox "Remove selected CCs" only if we have CC list.
Attachment #788046 - Flags: review?(sgreen)
This is actually a regression due to bug 819330 where $bug->cc now always returns an arrayref instead of undef when there is nobody in the CC list. This means [% bug.cc %] is now always true. It must now be [% bug.cc.size %] (> 0 is useless).

There are several other places in templates which also need to be fixed:

./bug/show-multiple.html.tmpl
./bug/edit.html.tmpl
./attachment/edit.html.tmpl
./attachment/create.html.tmpl
Depends on: 819330
Keywords: regression
Summary: Donot display "CC list box" and "Remove Selected CCs" if CC list has no users on show bug page. → Do not display the CC list and the "Remove selected CCs" checkbox if the CC list is empty
Target Milestone: --- → Bugzilla 4.4
Version: 4.5 → 4.4
Comment on attachment 788046 [details] [diff] [review]
Patch-v1

Please fix all 4 templates at once, even if the problem you describe is the single visible symptom.
Attachment #788046 - Attachment is obsolete: true
Attachment #788046 - Flags: review?(sgreen)
Attached patch Patch-v2 (obsolete) — — Splinter Review 

        Attachment #788069 -
        Flags: review?(sgreen)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch-v3
        — 
          — Splinter Review
      

    


  

        Attachment #788069 -
        Attachment is obsolete: true

        Attachment #788069 -
        Flags: review?(sgreen)

        Attachment #788077 -
        Flags: review?(sgreen)

    
  

        Attachment #788077 -
        Flags: review?(sgreen) → review+

    
  
Flags: approval?
Flags: approval4.4?

    
  
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+

    
    

    
  
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/attachment/create.html.tmpl
modified template/en/default/attachment/edit.html.tmpl
modified template/en/default/bug/edit.html.tmpl
modified template/en/default/bug/show-multiple.html.tmpl
Committed revision 8715.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.4/                         
modified template/en/default/attachment/create.html.tmpl
modified template/en/default/attachment/edit.html.tmpl
modified template/en/default/bug/edit.html.tmpl
modified template/en/default/bug/show-multiple.html.tmpl
Committed revision 8599.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: