903341 - Running configure with no configure.in change overwrites gyp generated Makefiles

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

+++ This bug was initially created as a clone of Bug #903321 +++

Namely, at least $objdir/Makefile and $objdir/js/src/Makefile. There's also media/webrtc and media/mtransport Makefiles, but that comes from gyp, so that would be a separate bug.

This makes us rebuild all of js, and a lot of tests that link against js_static.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Avoid gyp overwriting Makefiles when they wouldn't be modified

This gets me, after bug 903321, from 858 to 124 files rebuilt after touch configure.in.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Avoid gyp overwriting Makefiles when they wouldn't be modified

Like the second iteration of bug 903321, this avoids makefiles being regenerated each time when the python script changes.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 788168 [details] [diff] [review]
Avoid gyp overwriting Makefiles when they wouldn't be modified

Review of attachment 788168 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 4

[(not currently active) Ted Mielczarek]

I was confused by your comment 0, but it's just from the bug you cloned from. If the gyp->Makefile code was overwriting $objdir/Makefile I was going to be very worried!

I think I looked at doing this, but didn't because of the weird dependency problems (similar to what we have for moz.build). If, for example, you have:
foo.gyp -->
  $objdir/foo/project_one
  $objdir/foo/project_two

and foo.gyp has changed, but only in the project_two bits, then running "make" in project_one could result in $objdir/foo/project_one/Makefile not being changed, which might result in an infinite dependency loop.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ddea989dcb9

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ddea989dcb9