903355 - [HD] Back button divider not in the correct location

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Eric Pang [:epang] UX]

Attachment: Back Divider.png

Pavel, because of the up scaling the divider needs to be moved to the left where the dark (of the back back button) and light (of the header) meet.  Can you move the divider to the correct location? Let me know if you have any questions, thanks!

Comment 1

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: shot

Hey Eric can you explain what is the bug for ... because this shot is from my Peak and the header look 1x1 like the header on my unagi and I'm not sure what I need to do

Comment 2

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> Created attachment 788338 [details]
> shot
> 
> Hey Eric can you explain what is the bug for ... because this shot is from
> my Peak and the header look 1x1 like the header on my unagi and I'm not sure
> what I need to do

Hi Pavel, this only occurs on the HD device.  It's cause everything was sized up by 1.5x.  But Amy wasn't able to size a 1px line to 1 and a half pixels since it becomes fuzzy..so she left anything that is 1px at 1px.  Because of this the divider is not as wide.  If you look at the screenshot you can see how the divider needs to be moved one pixel to the left so that the dark side of the divider falls on the dark part of the header (back button) and the light part falls on the light side of the header.  It's most obvious at the top of the divider, it looks like the light side is spilling into the dark side of the header.  If you look at the 1x version you'll see it's a straight division line.  Let me know if I need to clarify more :). Thanks!

Comment 3

[Eric Pang [:epang] UX]

adding status-b2g-v1.1hd:? flag

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot

It looks much better on device

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/v1.1.0hd

Comment 6

[Eric Pang [:epang] UX]

Comment on attachment 789646 [details]
After patch screenshot

Great, thanks Pavel! I can see the issue has been fixed from the screenshot :)

Comment 7

[Sam Joch [:samjoch]]

Comment on attachment 789651 [details]
patch for Gaia/v1.1.0hd

Pavel, is there a specific reason why you target v1.1.0hd before master ?
i think you should PR master, no ?

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

(In reply to Sam Joch [:samjoch] from comment #7)
> Comment on attachment 789651 [details]
> patch for Gaia/v1.1.0hd
> 
> Pavel, is there a specific reason why you target v1.1.0hd before master ?
> i think you should PR master, no ?

This bug is only for HD do I need to make a patch for master too? Sorry if I miss something.

Comment 9

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #8)
> (In reply to Sam Joch [:samjoch] from comment #7)
> > Comment on attachment 789651 [details]
> > patch for Gaia/v1.1.0hd
> > 
> > Pavel, is there a specific reason why you target v1.1.0hd before master ?
> > i think you should PR master, no ?
> 
> This bug is only for HD do I need to make a patch for master too? Sorry if I
> miss something.

Sam, this is only for HD since it already appears correctly on master.  It was a due to a resizing issue.  Will this cause problems if the change is only on HD?

Comment 10

[Wayne Chang [:wchang]]

hd+ layout

Comment 11

[Sam Joch [:samjoch]]

Comment on attachment 789651 [details]
patch for Gaia/v1.1.0hd

Landed in v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/71382839267d21ffb9ccd52ae510bc2df11cc932

Comment 12

[Al Tsai [:atsai]]

[2013/10/21 Helix Testing]
Gaia:     c829a2042594b6c3a4899ee27979799a0f301534
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/f7c657f6d019
BuildID   20131015042201
Version   18.0