Closed Bug 903360 Opened 11 years ago Closed 11 years ago

[HD] Blue time stamp is too small and should be closer to the right edge

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
All
Other
Type:
defect

Tracking

(blocking-b2g:hd+, b2g-v1.1hd fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g hd+
Tracking Flags:
Tracking Status
b2g-v1.1hd --- fixed

People

(Reporter: epang, Assigned: pivanov)

Details

(Whiteboard: helix vsd, HD)

Attachments

(6 files)

Notification - Time Stamp.png
127.12 KB, image/png
Details
After patch screenshot
196.07 KB, image/png
epang
: feedback+
Details
patch for Gaia/master
183 bytes, text/html
sjochimek
: review+
Details
patch for Gaia/v1.1.0hd
183 bytes, text/html
sjochimek
: review+
Details
After patch screenshot
319.00 KB, image/png
Details
Notification Info.
115.91 KB, image/png
Details 
Pavel, can we increase the size of the time stamp to 12 pt on the notification panel. Can they also be right aligned with a 1.5 rem margin. Thanks!
Attached image After patch screenshot — 

        Attachment #788343 -
        Flags: feedback?(epang)

    
    

    
  
(In reply to Pavel Ivanov [:ivanovpavel] from comment #1)
> Created attachment 788343 [details]
> After patch screenshot

Much better, thanks Pavel!  Ready for review.

        Attachment #788349 -
        Flags: review?(sjochimek)

    
    

    
  
Comment on attachment 788349 [details]
patch for Gaia/master

Pavel: See my comment on Github. (Flag me back ;-))

        Attachment #788349 -
        Flags: review?(sjochimek)

    
    

    
  
Comment on attachment 788349 [details]
patch for Gaia/master

Thanks Sam you help me to find out one more thing and I fix the problems :) thanks again

        Attachment #788349 -
        Flags: review?(sjochimek)

    
    

    
  
adding status-b2g-v1.1hd:? flag

          status-b2g-v1.1hd:
          --- → ?

    
    

    
  
Eric: still ok for you ? I rather wait a feedback+ from visualteam.
Flags: needinfo?(epang)

    
    

    
  
Comment on attachment 788343 [details]
After patch screenshot

Yes, thanks Pavel.

        Attachment #788343 -
        Flags: feedback?(epang) → feedback+

    
    

    
  
hd+ layout
blocking-b2g: hd? → hd+

    
    

    
  
Comment on attachment 788349 [details]
patch for Gaia/master

Landed in master: https://github.com/mozilla-b2g/gaia/commit/58bb05efc83407428099a182244a1759ab84cd0b

        Attachment #788349 -
        Flags: review?(sjochimek) → review+

    
  
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(epang)
Resolution: --- → FIXED

    
    

    
  
Pavel: Seems to have conflicts when cherry-picked in v1.1.0hd, Can you take a look ?
Flags: needinfo?(pivanov)

    
    

    
  
Sure,
I will create a patch for v1.1.0hd :)
Flags: needinfo?(pivanov)

    
    

    
  


  

        Attachment #790971 -
        Flags: review?(sjochimek)

        Attachment #788349 -
        Attachment description: patch for Gaia repo → patch for Gaia/master

    
    

    
  
(In reply to Pavel Ivanov [:ivanovpavel] from comment #14)
> Created attachment 790992 [details]
> After patch screenshot

Looks good, thanks Pavel!

    
  
Whiteboard: helix vsd → helix vsd, HD

    
    

    
  
Comment on attachment 790971 [details]
patch for Gaia/v1.1.0hd

Landed in v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/910b989fed2ab13147a1bbcf0b2d9fa539a3e460

        Attachment #790971 -
        Flags: review?(sjochimek) → review+

    
    

    
  
The UI is better than before. Thanks for your help! Verified the patch.

* Test build:(Mozilla Central-helix/2013-08-25-04-22-01)
  + Mercurial-Information
    - Gecko revision="f392714dea0b"
  + Git-information
    - Gaia revision="7b61b7dc3400d5bea23d2b52948f4fded8259dfc"


Attaching the screenshot. Marked as verified.
Status: RESOLVED → VERIFIED

    
    

    
  

      
      
      
      

        Attached image
          
        Notification Info.
        — 
      

    


  

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: