Closed Bug 903363 Opened 11 years ago Closed 11 years ago

[HD] Arrows on utility tray are still SD

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
All
Other
Type:
defect

Tracking

(blocking-b2g:hd+, b2g-v1.1hd fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g hd+
Tracking Flags:
Tracking Status
b2g-v1.1hd --- fixed

People

(Reporter: epang, Assigned: pivanov)

Details

(Whiteboard: helix vsd, HD)

Attachments

(7 files, 3 obsolete files)

Notification Tray - Arrows.png
112.82 KB, image/png
Details
patch for Gaia/master
183 bytes, text/html
sjochimek
: review+
Details
arrows graphics
2.63 KB, application/x-zip-compressed
Details
After patch screenshot
191.36 KB, image/png
epang
: feedback+
Details
patch for Gaia/v1.1.0hd
183 bytes, text/html
Details
Render using v1.1.0hd ( + patch for v1.1.0hd)
60.36 KB, image/png
Details
Usage app - Arrows Icon
69.31 KB, image/png
Details 
Pavel, the arrows on the utility tray are still in SD.  I wasn't able to find the current graphic, can you send a link to the image being used so we can attach a unscaled version. Thanks!
adding status-b2g-v1.1hd:? flag
status-b2g-v1.1hd: --- → ?
Attached image After patch screenshot (obsolete) — 

        Attachment #790403 -
        Flags: feedback?(epang)

    
    

    
  

      
      
      
      

        Attached image
          
        After patch screenshot 2 (obsolete)
        — 
      

    


  

        Attachment #790405 -
        Flags: feedback?(epang)

    
    

    
  
HD+ asset
blocking-b2g: hd? → hd+

    
    

    
  
Comment on attachment 790403 [details]
After patch screenshot

The arrows are looking too big, attaching new graphics soon.

        Attachment #790403 -
        Flags: feedback?(epang) → feedback-

    
    

    
  
Comment on attachment 790405 [details]
After patch screenshot 2

The arrows are looking too big, attaching new graphics soon.

        Attachment #790405 -
        Flags: feedback?(epang) → feedback-

    
    

    
  

      
      
      
      

        Attached file
          
        arrows graphics
        — 
      

    


  
Pavel, i've reduced the size of the arrows.  I've included the asserts for sd, hd and 2x.  Can you update them and then flag me for feedback?  Thanks!
Flags: needinfo?(pivanov)

        Attachment #790403 -
        Attachment is obsolete: true

        Attachment #790405 -
        Attachment is obsolete: true

    
    

    
  

      
      
      
      

        Attached image
          
        After patch screenshot (obsolete)
        — 
      

    


  

        Attachment #790770 -
        Flags: feedback?(epang)
Flags: needinfo?(pivanov)

    
    

    
  
(In reply to Pavel Ivanov [:ivanovpavel] from comment #9)
> Created attachment 790770 [details]
> After patch screenshot

Pavel, are these the new icons i provided?  They still look really big!
Flags: needinfo?(pivanov)

        Attachment #790770 -
        Attachment is obsolete: true

        Attachment #790770 -
        Flags: feedback?(epang)

    
    

    
  

      
      
      
      

        Attached image
          
        After patch screenshot
        — 
      

    


  
Hey Eric, 
you are right. It's my fault, I was uploaded wrong image. Now is the right one

        Attachment #791937 -
        Flags: feedback?(epang)
Flags: needinfo?(pivanov)

    
    

    
  


  

        Attachment #791938 -
        Flags: review?(sjochimek)

    
    

    
  
Comment on attachment 791937 [details]
After patch screenshot

Thanks Pavel :)

        Attachment #791937 -
        Flags: feedback?(epang) → feedback+

        Attachment #790407 -
        Flags: review?(sjochimek)

    
    

    
  


  
Still have image issues ! I think you don't need to resize images between master & v1.1.0.
Why for instance: apps/costcontrol/style/images/widget/icons/icon-go@1.5x.png
is 14px x 26px in v1.1.0hd patch and in master patch it's 45px x 45px ?

(Flag me back)
Flags: needinfo?(pivanov)

    
  

        Attachment #790407 -
        Flags: review?(sjochimek)

    
  

        Attachment #791938 -
        Flags: review?(sjochimek)

    
    

    
  
Comment on attachment 790407 [details]
patch for Gaia/master

right Sam, thanks for the catch

        Attachment #790407 -
        Flags: review?(sjochimek)

    
  
Whiteboard: helix vsd → helix vsd, HD

    
  
Status: NEW → RESOLVED
Closed: 11 years ago

          status-b2g-v1.1hd:
          affected → fixed
Flags: needinfo?(pivanov)
Resolution: --- → FIXED

    
    

    
  
Thank you!

Verified it on following build. Attaching screenshot.

Test Build:
- PVT Build: Mozilla-b2g18_v1_1_0_hd-helix/2013-09-05-04-22-01
- Gecko revision="838455b3eb13"
- Gaia revision="5e784f0763133015f3cdf059554ef266ce561a2e"
- Gecko version: 26.0a1
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: