903365 - [Settings][HD] Settings icons inner shadow is too dark - tone down

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Eric Pang [:epang] UX]

Amy, once you have the sprite ready can you attach and assign the bug to Pavel for implementation? Thanks!

Comment 1

[Amy Lee [:amylee] UX]

Attachment: New Settings [e-mail]

Hi, 

Attached are the updated icons.

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: shot

I saw some small change on one Icon. Do we need to change the sprite also for SD and 2.x? or this change is only for 1.5?

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 4

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #3)
> Created attachment 788181 [details]
> patch for Gaia repo

Hi Pavel, this is only for 1.5. Since the icons look good on SD already. Thanks!

Comment 5

[Amy Lee [:amylee] UX]

Attachment: Language_Icon_Update.zip

Hi, 

Sorry Pavel, can you please use these sprites instead? I've adjusted the positioning of the language icon slightly. Please also update @1 and @2 scale sprites. Thanks!

Comment 6

[Sam Joch [:samjoch]]

Comment on attachment 788181 [details]
patch for Gaia/master

Landed in master: https://github.com/mozilla-b2g/gaia/commit/afa549fc2afd50f923d73dbb05a9ab36e366cf23

Comment 7

[Eric Pang [:epang] UX]

adding status-b2g-v1.1hd:? flag

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/v1.1.0hd

Comment 9

[Sam Joch [:samjoch]]

Comment on attachment 791000 [details]
patch for Gaia/v1.1.0hd

Landed in v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/cb3b56f74c9eb8ac9381f6e604e63e3004691ada

Comment 10

[Amy Lee [:amylee] UX]

Hi, 

I notice that there is a faint line next to the "language" icon. Has anyone else noticed this? 

Thanks

Comment 11

[Eric Pang [:epang] UX]

(In reply to Amy from comment #10)
> Hi, 
> 
> I notice that there is a faint line next to the "language" icon. Has anyone
> else noticed this? 
> 
> Thanks

Pavel, I've checked and see the same thing.  If Amy provides you with an updated sprite can you replace?  Do we need to open a new bug? Let us know, Thanks!

Amy, it looks like half a pixel of the keyboard icons is the problem.  You'll just need to shift it a bit so it doesn't go into the space of the language icon.

Comment 12

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Sure,
I think we need to open a new bug for this because this one is fixed.

Comment 13

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #12)
> Sure,
> I think we need to open a new bug for this because this one is fixed.

Opened this bug as a follow up for the hair line next to the language icon: 911962

Comment 14

[William Hsu [:whsu]]

Thank for your help!
Verified it.

* Test build:(Mozilla-b2g18_v1_1_0_hd-helix/2013-09-05-04-22-01)
  + Mercurial-Information
    - Gecko revision="838455b3eb13"
  + Git-information
    - Gaia revision="f0d08182afbf424b405b1d3864f557ef7c4f70c1"
  + Gecko version: 18.0

Comment 15

[William Hsu [:whsu]]

Attachment: SettingsApp - Inner shadow

Comment 16

[Jason Smith [:jsmith]]

Mass-modify - removal of no longer relevant blocking flags.