[Settings][HD] Settings icons inner shadow is too dark - tone down

VERIFIED FIXED

Status

Firefox OS
Gaia::Settings
P1
normal
VERIFIED FIXED
5 years ago
3 years ago

People

(Reporter: epang, Assigned: amylee)

Tracking

unspecified
All
Other

Firefox Tracking Flags

(b2g-v1.1hd fixed)

Details

(Whiteboard: helix vsd, HD)

Attachments

(6 attachments)

(Reporter)

Description

5 years ago
Amy, once you have the sprite ready can you attach and assign the bug to Pavel for implementation? Thanks!
(Assignee)

Comment 1

5 years ago
Created attachment 788152 [details]
New Settings Icons@1.5.zip

Hi, 

Attached are the updated icons.
Created attachment 788180 [details]
shot

I saw some small change on one Icon. Do we need to change the sprite also for SD and 2.x? or this change is only for 1.5?
Flags: needinfo?(epang)
Created attachment 788181 [details]
patch for Gaia/master
(Reporter)

Comment 4

5 years ago
(In reply to Pavel Ivanov [:ivanovpavel] from comment #3)
> Created attachment 788181 [details]
> patch for Gaia repo

Hi Pavel, this is only for 1.5. Since the icons look good on SD already. Thanks!
Flags: needinfo?(epang)
(Assignee)

Comment 5

5 years ago
Created attachment 788244 [details]
Language_Icon_Update.zip

Hi, 

Sorry Pavel, can you please use these sprites instead? I've adjusted the positioning of the language icon slightly. Please also update @1 and @2 scale sprites. Thanks!
Attachment #788181 - Flags: review?(sjochimek)

Comment 6

5 years ago
Comment on attachment 788181 [details]
patch for Gaia/master

Landed in master: https://github.com/mozilla-b2g/gaia/commit/afa549fc2afd50f923d73dbb05a9ab36e366cf23
Attachment #788181 - Flags: review?(sjochimek) → review+

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 7

5 years ago
adding status-b2g-v1.1hd:? flag
status-b2g-v1.1hd: --- → ?
Attachment #788181 - Attachment description: patch for Gaia repo → patch for Gaia/master
Created attachment 791000 [details]
patch for Gaia/v1.1.0hd
Attachment #791000 - Flags: review?(sjochimek)
(Reporter)

Updated

5 years ago
Whiteboard: helix vsd → helix vsd, HD

Comment 9

5 years ago
Comment on attachment 791000 [details]
patch for Gaia/v1.1.0hd

Landed in v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/cb3b56f74c9eb8ac9381f6e604e63e3004691ada
Attachment #791000 - Flags: review?(sjochimek) → review+

Updated

5 years ago
status-b2g-v1.1hd: ? → fixed
(Assignee)

Comment 10

5 years ago
Hi, 

I notice that there is a faint line next to the "language" icon. Has anyone else noticed this? 

Thanks
(Reporter)

Comment 11

4 years ago
(In reply to Amy from comment #10)
> Hi, 
> 
> I notice that there is a faint line next to the "language" icon. Has anyone
> else noticed this? 
> 
> Thanks

Pavel, I've checked and see the same thing.  If Amy provides you with an updated sprite can you replace?  Do we need to open a new bug? Let us know, Thanks!

Amy, it looks like half a pixel of the keyboard icons is the problem.  You'll just need to shift it a bit so it doesn't go into the space of the language icon.
Flags: needinfo?(pivanov)
Sure,
I think we need to open a new bug for this because this one is fixed.
Flags: needinfo?(pivanov)
(Reporter)

Comment 13

4 years ago
(In reply to Pavel Ivanov [:ivanovpavel] from comment #12)
> Sure,
> I think we need to open a new bug for this because this one is fixed.

Opened this bug as a follow up for the hair line next to the language icon: 911962

Comment 14

4 years ago
Thank for your help!
Verified it.

* Test build:(Mozilla-b2g18_v1_1_0_hd-helix/2013-09-05-04-22-01)
  + Mercurial-Information
    - Gecko revision="838455b3eb13"
  + Git-information
    - Gaia revision="f0d08182afbf424b405b1d3864f557ef7c4f70c1"
  + Gecko version: 18.0
Status: RESOLVED → VERIFIED

Comment 15

4 years ago
Created attachment 802219 [details]
SettingsApp - Inner shadow
Mass-modify - removal of no longer relevant blocking flags.

Updated

3 years ago
blocking-b2g: hd? → ---
You need to log in before you can comment on or make changes to this bug.