Closed
Bug 903365
Opened 11 years ago
Closed 11 years ago
[Settings][HD] Settings icons inner shadow is too dark - tone down
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect, P1)
Tracking
(b2g-v1.1hd fixed)
VERIFIED
FIXED
Tracking | Status | |
---|---|---|
b2g-v1.1hd | --- | fixed |
People
(Reporter: epang, Assigned: amylee)
Details
(Whiteboard: helix vsd, HD)
Attachments
(6 files)
Amy, once you have the sprite ready can you attach and assign the bug to Pavel for implementation? Thanks!
Assignee | ||
Comment 1•11 years ago
|
||
Hi, Attached are the updated icons.
Comment 2•11 years ago
|
||
I saw some small change on one Icon. Do we need to change the sprite also for SD and 2.x? or this change is only for 1.5?
Flags: needinfo?(epang)
Comment 3•11 years ago
|
||
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to Pavel Ivanov [:ivanovpavel] from comment #3) > Created attachment 788181 [details] > patch for Gaia repo Hi Pavel, this is only for 1.5. Since the icons look good on SD already. Thanks!
Flags: needinfo?(epang)
Assignee | ||
Comment 5•11 years ago
|
||
Hi, Sorry Pavel, can you please use these sprites instead? I've adjusted the positioning of the language icon slightly. Please also update @1 and @2 scale sprites. Thanks!
Updated•11 years ago
|
Attachment #788181 -
Flags: review?(sjochimek)
Comment 6•11 years ago
|
||
Comment on attachment 788181 [details] patch for Gaia/master Landed in master: https://github.com/mozilla-b2g/gaia/commit/afa549fc2afd50f923d73dbb05a9ab36e366cf23
Attachment #788181 -
Flags: review?(sjochimek) → review+
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment #788181 -
Attachment description: patch for Gaia repo → patch for Gaia/master
Comment 8•11 years ago
|
||
Attachment #791000 -
Flags: review?(sjochimek)
Reporter | ||
Updated•11 years ago
|
Whiteboard: helix vsd → helix vsd, HD
Comment 9•11 years ago
|
||
Comment on attachment 791000 [details] patch for Gaia/v1.1.0hd Landed in v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/cb3b56f74c9eb8ac9381f6e604e63e3004691ada
Attachment #791000 -
Flags: review?(sjochimek) → review+
Updated•11 years ago
|
Assignee | ||
Comment 10•11 years ago
|
||
Hi, I notice that there is a faint line next to the "language" icon. Has anyone else noticed this? Thanks
Reporter | ||
Comment 11•11 years ago
|
||
(In reply to Amy from comment #10) > Hi, > > I notice that there is a faint line next to the "language" icon. Has anyone > else noticed this? > > Thanks Pavel, I've checked and see the same thing. If Amy provides you with an updated sprite can you replace? Do we need to open a new bug? Let us know, Thanks! Amy, it looks like half a pixel of the keyboard icons is the problem. You'll just need to shift it a bit so it doesn't go into the space of the language icon.
Flags: needinfo?(pivanov)
Comment 12•11 years ago
|
||
Sure, I think we need to open a new bug for this because this one is fixed.
Flags: needinfo?(pivanov)
Reporter | ||
Comment 13•11 years ago
|
||
(In reply to Pavel Ivanov [:ivanovpavel] from comment #12) > Sure, > I think we need to open a new bug for this because this one is fixed. Opened this bug as a follow up for the hair line next to the language icon: 911962
Comment 14•11 years ago
|
||
Thank for your help! Verified it. * Test build:(Mozilla-b2g18_v1_1_0_hd-helix/2013-09-05-04-22-01) + Mercurial-Information - Gecko revision="838455b3eb13" + Git-information - Gaia revision="f0d08182afbf424b405b1d3864f557ef7c4f70c1" + Gecko version: 18.0
Status: RESOLVED → VERIFIED
Comment 15•11 years ago
|
||
Comment 16•10 years ago
|
||
Mass-modify - removal of no longer relevant blocking flags.
Updated•10 years ago
|
blocking-b2g: hd? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•