Closed Bug 903387 Opened 7 years ago Closed 7 years ago

Backport bug 240437 (last_seen_date column) to BMO 4.2

Categories

(bugzilla.mozilla.org :: General, defect)

Production
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: gerv, Assigned: gerv)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 240437 has a small patch which adds and populates a last_seen_date column in the user profile table. There are a number of uses for this, and backporting it to current BMO would mean that the data would start getting populated, which would be useful when we come to make use of the data.

One example use would be to update the Review extension to not allow requesting review from someone who had not been seen for the last N months (e.g. N=3). This will reduce the risk of people requesting review from other people who are very unlikely to do it.

The last_seen_date is a small patch and it's already integrated into 4.4 and has been there for 18 months without causing any problems.

Gerv
Attached patch Patch v.1 (obsolete) — Splinter Review
Assignee: nobody → gerv
Status: NEW → ASSIGNED
Attachment #788103 - Flags: review?(dkl)
Comment on attachment 788103 [details] [diff] [review]
Patch v.1

Review of attachment 788103 [details] [diff] [review]:
-----------------------------------------------------------------

Otherwise looks fine and works well. r=dkl

::: Bugzilla/Install/DB.pm
@@ +657,5 @@
>      # 2011-06-15 dkl@mozilla.com - Bug 658929
>      _migrate_disabledtext_boolean();
>  
> +    # 2011-11-01 glob@mozilla.com - Bug 240437
> +    $dbh->bz_add_column('profiles', 'last_seen_date', {TYPE => 'DATETIME'});

nit: date not in chronological order
Attachment #788103 - Flags: review?(dkl) → review+
dkl: are you saying 2011-11-01 is before 2011-06-15?

Gerv
(In reply to Gervase Markham [:gerv] from comment #3)
> dkl: are you saying 2011-11-01 is before 2011-06-15?
> 
> Gerv

No I am saying 2011-11-01 is after 2011-10-11.

+    # 2011-11-01 glob@mozilla.com - Bug 240437
+    $dbh->bz_add_column('profiles', 'last_seen_date', {TYPE => 'DATETIME'});
+
     # 2011-10-11 miketosh - Bug 690173

dkl
Attached patch 903387.diffSplinter Review
Patch v.2 with nit fixed; carrying forward r+.

Gerv
Attachment #788103 - Attachment is obsolete: true
Attachment #790535 - Flags: review+
as this alters the profiles table, this need to be deployed during the next downtime.
Blocks: 900375
Committed for tomorrows push.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2
modified Bugzilla.pm
modified editusers.cgi
modified Bugzilla/User.pm
modified Bugzilla/DB/Schema.pm
modified Bugzilla/Install/DB.pm
modified template/en/default/admin/users/edit.html.tmpl
modified template/en/default/admin/users/list.html.tmpl
Committed revision 8966.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.