Closed Bug 903396 Opened 6 years ago Closed 6 years ago

Make about:networking more toolkit friendly

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: philip.chee, Assigned: robertbindar)

References

Details

Attachments

(1 file)

Everything else lives in Core or Toolkit except for:
https://hg.mozilla.org/mozilla-central/rev/dcb7c39d1cf8#l1.12
> 1.12 +// Warning for about:networking page
> 1.13 +pref("network.warnOnAboutNetworking", true);

This causes the following line to throw in any other toolkit application:
https://hg.mozilla.org/mozilla-central/rev/dcb7c39d1cf8#l5.123
>  5.123 +  if (gPrefs.getBoolPref("warnOnAboutNetworking")) {

So either move the pref to /modules/libpref/src/init/all.js
and/or wrap the call to get the pref in a try/catch block. e.g.

let warn = true;
try {warn = gPrefs.getBoolPref("warnOnAboutNetworking")} catch (e) { }
if (warn) ...
Blocks: 865850
No longer depends on: 865850
Blocks: 903409
Assignee: nobody → valentin.gosu
Attachment #788578 - Flags: review?(benjamin)
Attachment #788578 - Flags: review?(benjamin) → review+
Sorry, I didn't know exactly who should I call for review.
https://tbpl.mozilla.org/?tree=Try&rev=ed5ebf2e3760
Assignee: valentin.gosu → robertbindar
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ea262c713de5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.