903438 - [Settings][HD] Text spacing incorrect in "Call Settings" and "Celluar & Data"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Eric Pang [:epang] UX]

Attachment: Settings - Spacing.png

Pavel, can you update the spacing so it's consistent with the other setting pages? See attached image. Thanks!

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

We need to use this bug.

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia repo

Comment 5

[Julien Wajsberg [:julienw]]

Pavel: afaik this happens the same on non-hd and hd devices, right ?

Comment 6

[Julien Wajsberg [:julienw]]

Note that I filed duplicate bug 883302 some time ago and that it got leo-minused 2 months ago. Love this.

Comment 7

[Julien Wajsberg [:julienw]]

Pavel: reading bug 831429 comment 25, do you think there is a bug in Gecko ? or is Gecko working as expected here ?

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Yep, does not depend on the resolution and I think it's not a Gecko bug. It's related with the l10n maybe... because if we have <a data-href="#call-voiceMailSettings" data-l10n-id="voiceMail">Voicemail</a> we have a problem ... but if we have <a data-href="#call-voiceMailSettings" data-l10n-id="voiceMail"> Voicemail </a> it works ... and when I try to make a test case everything work normal because I don't use l10n

Comment 9

[Julien Wajsberg [:julienw]]

nominating leo instead of hd because it does not depend on the resolution.

(I personally think this should not block)

Pavel, I don't see how l10n could change CSS rendering... Maybe you can try to do a testcase with the l10n library ?

Comment 10

[Lukas Blakk [:lsblakk] use ?needinfo]

Not blocking since we're not losing info on the screenshots, but flagging UX team so it's on their radar.

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 788206 [details]
patch for Gaia repo

r=me with the nit

simple fix, thanks !

But this still smells like a workaround, I still would like to know why we need this padding.

Comment 12

[Stephany Wilkes]

Flagging Eric to advise on padding.

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks Julien,
I will try to find out what happened there.

Comment 14

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/18d8efc064cdd493f4f369e65e5abb761ac07d60

Landed in v1.1.0hd:
https://github.com/mozilla-b2g/gaia/commit/3523e8c7d95b6e183f302808d3bc9cd33d8833b6

Comment 15

[Julien Wajsberg [:julienw]]

Pavel, why have you merged in 1.1.0hd ? This bug was not hd+...

I mean, it's not a big deal, and you know I'd like to see this in 1.1, but it was minused in comment 10...

Comment 16

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

(In reply to Julien Wajsberg [:julienw] from comment #15)
> Pavel, why have you merged in 1.1.0hd ? This bug was not hd+...
> 
> I mean, it's not a big deal, and you know I'd like to see this in 1.1, but
> it was minused in comment 10...

I just thinking that this is also for SD and HD. Eric asked Tim about landing HD bugs bug maybe I'm misunderstood. Sorry about this :(

Comment 17

[Eric Pang [:epang] UX]

Hi Julien, i'm nomonating this as HD? since Pavel was correct to land in v1.1.0hd.  I should have nominated this earlier. Thanks!

Comment 18

[Julien Wajsberg [:julienw]]

Eric, you actually did, then I asked for leo because this is not a hd bug, and then it was minused.

As I said, I'd be happy to see this in both 1.1 branches, but we have processes...

Comment 19

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

(In reply to Julien Wajsberg [:julienw] from comment #18)
> Eric, you actually did, then I asked for leo because this is not a hd bug,
> and then it was minused.
> 
> As I said, I'd be happy to see this in both 1.1 branches, but we have
> processes...

Hey Julien,
I want to do it right, what I need to do now? (we have some other bugs who are in situation like this one and I want to prevent them for not correct landing of patches)

Comment 20

[Julien Wajsberg [:julienw]]

Just wait that hd+ and/or leo+ are set. hd+ should be to bugs specific to the hd devices, and leo+ for all 1.1 bugs. When you land it, you need to set the tracking flags too, for easy tracking ! usually you don't need to land it yourself, we have sheriff that do that according to the flags.

If it's minused, then just don't land it on the branches, it will be in 1.2.

As for this bug, I sincerely think it should be leo+ so that both branches are in sync, but you should wait for it...

Comment 21

[Eric Pang [:epang] UX]

(In reply to Julien Wajsberg [:julienw] from comment #20)
> Just wait that hd+ and/or leo+ are set. hd+ should be to bugs specific to
> the hd devices, and leo+ for all 1.1 bugs. When you land it, you need to set
> the tracking flags too, for easy tracking ! usually you don't need to land
> it yourself, we have sheriff that do that according to the flags.
> 
> If it's minused, then just don't land it on the branches, it will be in 1.2.
> 
> As for this bug, I sincerely think it should be leo+ so that both branches
> are in sync, but you should wait for it...

Pavel, I've added the tracking flag for the hd bugs we've opened so you don't have to worry about it :)

Comment 22

[William Hsu [:whsu]]

Thanks for your help!
Verified on the V1.1.0 HD build with latest helix base image(0805).
Marked as "Verified"+"Fixed"

* Test build:(Mozilla-b2g18_v1_1_0_hd-helix/2013-08-15-04-22-01)
  + Mercurial-Information
    - Gecko revision="bd0864949c0f"
  + Git-information
    - Gaia revision="d04d2d3969e4366fabafe9659f9b2705b7879ac2"

Attaching the screen shot

Comment 23

[William Hsu [:whsu]]

Attachment: Text spacing

Comment 24

[Eric Pang [:epang] UX]

(In reply to William Hsu [:whsu] from comment #23)
> Created attachment 791162 [details]
> Text spacing

looks great, thanks guys!

Comment 25

[Jason Smith [:jsmith]]

Mass-modify - removal of no longer relevant blocking flags.