903549 - build failure in mozilla-release using webrtc and pulseaudio

Status: RESOLVED DUPLICATE of bug 897300

(Core :: WebRTC, defect)

Description

[Christoph Moench-Tegeder]

Attachment: fix variable naming in media/webrtc/trunk/webrtc/modules/audio_device/linux/audio_device_pulse_linux.h

User Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130809184443

Steps to reproduce:

building firefox from source (firefox-23.0.source.tar.bz2) with pulseaudio enable (--enable-pulseaudio) fails with

<pre>
/usr/ports/www/firefox/work/mozilla-release/media/webrtc/trunk/webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc:82:5: error: initializer 'sample_rate_hz_' does not name a non-static data member or base class; did you mean the member 'sampling_rate_hz'?
    sample_rate_hz_(0),
    ^~~~~~~~~~~~~~~
    sampling_rate_hz
/usr/ports/www/firefox/work/mozilla-release/media/webrtc/trunk/webrtc/modules/audio_device/linux/audio_device_pulse_linux.h:313:19: note: 'sampling_rate_hz' declared here
    WebRtc_Word32 sampling_rate_hz;
                  ^
</pre>

and some other errors in the same vain.
Checking mercurial, I see that the commit for Bug 886886 was done correctly in mozilla-central: http://hg.mozilla.org/mozilla-central/rev/776fa6a8a552#l6.32 but the sample rate was named sampling_rate_hz in mozilla-release: http://hg.mozilla.org/releases/mozilla-release/rev/50843553c782#l6.33 which looks rather unintentional.
The patch is rather trivial and attached.


Actual results:

the build failed (error message see above)


Expected results:

i get firefox 23

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

This was fixed on Aurora/24 in bug 897300, but we hadn't noticed it affected FF23 as well since Pulse doesn't get built by default.

This would only affect non-Mozilla-official builds

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

No need to track for release, this is already fixed on beta (24) and anyone who wants this can take it from there for their own builds.

Comment 3

[Jan Beich]

ff23 is long since EOL to keep it open.