Fix bsdiff.exe and mar.exe permissions

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rail, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
permission check failed during 24.0b1:

-bash-4.1$ find /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/ -type f ! -perm 644 -ls
2047427   20 -rwxr-xr-x   1 ffxbld   firefox     19128 Aug  7 21:58 /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/mar-tools/macosx64/mar
2047428   16 -rwxr-xr-x   1 ffxbld   firefox     13520 Aug  7 21:58 /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/mar-tools/macosx64/mbsdiff
2047430   20 -rwxr-xr-x   1 ffxbld   firefox     18254 Aug  7 21:58 /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/mar-tools/linux64/mar
2047431   16 -rwxr-xr-x   1 ffxbld   firefox     12732 Aug  7 21:58 /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/mar-tools/linux64/mbsdiff
2047433   16 -rwxr-xr-x   1 ffxbld   firefox     15116 Aug  7 21:58 /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/mar-tools/linux/mar
2047434   12 -rwxr-xr-x   1 ffxbld   firefox     10194 Aug  7 21:58 /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/mar-tools/linux/mbsdiff
2047436   88 -rwxr-xr-x   1 ffxbld   firefox     83968 Aug  7 21:58 /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/mar-tools/win32/mar.exe
1419265   12 -rwxr-xr-x   1 ffxbld   firefox     10240 Aug  7 21:58 /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/mar-tools/win32/mbsdiff.exe
-bash-4.1$ find /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/ -type f ! -perm 644 -exec chmod 644 {} \;
-bash-4.1$ find /pub/mozilla.org/firefox/candidates/24.0b1-candidates/build2/ -type f ! -perm 644 -ls
These got transferred over by hand in the 24.0b1 cycle, and I made them executable on purpose. It doesn't really matter though, because we set the perms on the slave when we download the tools:

https://hg.mozilla.org/build/tools/file/8909056e85b0/lib/python/build/l10n.py#l159

I think the permissions will be correct when the tools are actually generated and uploaded as part of 24.0b2. If they're not, I can look into fixing post_upload.py.
Product: mozilla.org → Release Engineering
(Reporter)

Comment 2

5 years ago
ran fine in 24.0b2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.