Closed
Bug 903569
Opened 11 years ago
Closed 11 years ago
Do we still need the CheckPropertyAccess bit in the GSP
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
1.99 KB,
patch
|
peterv
:
review+
bholley
:
review+
|
Details | Diff | Splinter Review |
With the patch for bug 895758 it's in WindowNamedPropertiesHandler and without that patch it's in nsWindowSH::GlobalScopePolluterGetProperty. But is it needed?
Flags: needinfo?(bobbyholley+bmo)
|
||
Comment 1•11 years ago
|
||
It calls into a bunch of CAPS code that I don't fully understand (especially the domain policy stuff). I haven't tried to rip it out yet because that's also the mechanism that implements nsISecurityCheckedComponent, which I haven't ripped out yet (bug 794943). But as far as I know, there is no useful security check that this is performing for the GSP. I say kill it.
Flags: needinfo?(bobbyholley+bmo)
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #796426 -
Flags: review?(peterv)
Attachment #796426 -
Flags: review?(bobbyholley+bmo)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [need review]
|
|
||
Updated•11 years ago
|
Attachment #796426 -
Flags: review?(bobbyholley+bmo) → review+
|
||
Updated•11 years ago
|
Attachment #796426 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/197f0dea9407
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla27
https://hg.mozilla.org/mozilla-central/rev/197f0dea9407
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•