Clean up the code for converting to/from value grips

NEW
Unassigned

Status

P3
normal
5 years ago
5 months ago

People

(Reporter: bbenvie, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
There's a number of places code that manipulates value grips exists. The function "createValueGrip" is replicated, with minor variations, in at least three places. These should be merged into one function. It would also be good to have a function that does the opposite, "gripToValue" or something.
(Reporter)

Updated

5 years ago
Depends on: 897256

Comment 1

5 years ago
Brandon,

I'll work on this bug. Although I suspect I'll need some help since this is only my second ticket.
(Reporter)

Comment 2

5 years ago
This might not be the best bug to work on as one of your first. While most of it is simple, there's some hairy details at the edge due to needing to create object grips in different ways between the difference implementations of createValueGrip.

Comment 3

5 years ago
Ok, I'll look around for a bug that's more suitable to my skill level. Thanks.
Priority: -- → P3

Updated

4 years ago
Summary: DRY up code for converting to/from Value Grips → Clean up the code for converting to/from value grips

Updated

4 years ago
Blocks: 1074538

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.