903624 - qimportbz not compatible with Mercurial 2.7 ("TypeError: promptchoice() takes at most 3 arguments (4 given)")

Status: RESOLVED DUPLICATE of bug 967280

(Developer Services :: Mercurial: qimportbz, defect)

Description

[Gregory Szorc [:gps]]

qimportbz blows up with Mercurial 2.7 :(

Traceback (most recent call last):
  File "/home/gps/bin/hg", line 38, in <module>
    mercurial.dispatch.run()
  File "/home/gps/lib/python/mercurial/dispatch.py", line 28, in run
    sys.exit((dispatch(request(sys.argv[1:])) or 0) & 255)
  File "/home/gps/lib/python/mercurial/dispatch.py", line 69, in dispatch
    ret = _runcatch(req)
  File "/home/gps/lib/python/mercurial/dispatch.py", line 97, in _runcatch
    return _dispatch(req)
  File "/home/gps/lib/python/mercurial/dispatch.py", line 778, in _dispatch
    cmdpats, cmdoptions)
  File "/home/gps/lib/python/mercurial/dispatch.py", line 549, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/home/gps/lib/python/mercurial/extensions.py", line 188, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/home/gps/lib/python/hgext/pager.py", line 132, in pagecmd
    return orig(ui, options, cmd, cmdfunc)
  File "/home/gps/lib/python/mercurial/extensions.py", line 188, in wrap
    return wrapper(origfn, *args, **kwargs)
  File "/home/gps/lib/python/hgext/color.py", line 412, in colorcmd
    return orig(ui_, opts, cmd, cmdfunc)
  File "/home/gps/lib/python/mercurial/dispatch.py", line 869, in _runcommand
    return checkargs()
  File "/home/gps/lib/python/mercurial/dispatch.py", line 840, in checkargs
    return cmdfunc()
  File "/home/gps/lib/python/mercurial/dispatch.py", line 775, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **cmdoptions)
  File "/home/gps/lib/python/mercurial/util.py", line 506, in check
    return func(*args, **kwargs)
  File "/home/gps/lib/python/mercurial/extensions.py", line 143, in wrap
    util.checksignature(origfn), *args, **kwargs)
  File "/home/gps/lib/python/mercurial/util.py", line 506, in check
    return func(*args, **kwargs)
  File "/home/gps/.mozbuild/hg_extensions/qimportbz/__init__.py", line 186, in qimporthook
    newpatchname = checkpatchname(patch)
  File "/home/gps/.mozbuild/hg_extensions/qimportbz/__init__.py", line 124, in checkpatchname
    0)
TypeError: promptchoice() takes at most 3 arguments (4 given)

Comment 1

[Eric Rescorla (:ekr)]

Attachment: promptchoice fix

Comment 2

[Eric Rescorla (:ekr)]

Comment on attachment 790931 [details] [diff] [review]
promptchoice fix

The promptchoice interface has changed.

This patch fixes things for current hg, but probably needs to be conditionalized on hg version

Comment 3

[Gregory Szorc [:gps]]

For inspiration: https://github.com/pbiggar/trychooser/commit/d8ece90a76058388a8e0e7c035c396dcf8b76ae2