90368 - [RFE] email address as tooltip in brief header display

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement)

Description

[Ben Ruppel]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.2+)
Gecko/20010710
BuildID:    2001071004

In the mailnews 3-pane, one can choose either brief or long (or is it
collapsed/expanded) when displaying an email.  For me, long is almost never
useful and I could keep it collapsed 90% of the time except for A) attachments
and B) the sender's email address.  (A) is a bit rough, but (B) shouldn't be too
tough (hence this bug is only for (B)).  

Right now, only the person's name is displayed in brief mode.  But it seems like
there is plenty of room to put their email address in there as well.  This would
greatly improve the interface for me.

Reproducible: Always
Steps to Reproduce:
1.open mailnews
2.select a message
3.collapse the header of the message

Actual Results:  sender's "name" is displayed, but not their email address.

Expected Results:  display their email address next to their name (like in the
From field when the header is expanded). If this is objectionable, how about a
tooltip that displays the address?

Comment 1

[Håkan Waara]

Message header bugs goes to mscott, I think.

Comment 2

[Ben Ruppel]

Question: could this be fixed with Gerv's patchmaker program? (I'm talking about
either the tooltip or displaying the email address.)

Comment 3

[Ben Ruppel]

Hi, I was able to give email addresses tooltips in the collapsed header state by
editing line 73 of msgHdrViewOverlay.xul. (part of messenger.jar)  So far, I have:
          <mail-emailaddress id="collapsedfromValue" flex="1" tooltip="aTooltip"
tooltiptext="&currentHeaderData[1].headerValue"/>

Problem is, I can't seem to pass the From header text to the tooltiptext.  It's
probably just a matter of finding the right variable or format for the variable
(the current line crashes).  If someone who knows a little more of the code
could put this in, we could gain a nice little feature.

Comment 4

[scottputterman]

adding jglick for opinions on this UI.

Comment 5

[jglick]

Cc'ing Marlon. Showing only the name (not email) in collapsed state was his 
suggestion for saving real estate in this mode. What about showing the email 
address in the status bar on hover?

Comment 6

[Ben Ruppel]

jglick: Using the status bar would be a great idea.  

It was a good idea to save real estate, but there just isn't a way to get the
real email address from a message without expending your header.  I was working
on a tooltip solution as a side project, but that would have been useless
without approval anyway :)

Comment 7

[jglick]

Ben, displaying the full email address in the statusbar on hover would be nice.

Or, if you wanna experiment with including the email address with the name in 
the collapsed header, thats fine too. When the design of the collapsed header 
was originally proposed, some alternate designs were proposed. You can see some 
of them here:
http://www.mozilla.org/mailnews/specs/proposals/images/Open8.gif
The second item shows the collapsed header with the full email address. If you 
prefer this route, we just need to be sure that the window truncates the header 
information correctly (and adequate spacing between items remains) as the window 
is made smaller.

Comment 8

[jglick]

*** Bug 132502 has been marked as a duplicate of this bug. ***

Comment 9

[Mike Lee]

I personally think it's more approperate to show the email as a tooltip (patch 
attached to Bug 132502). However I'll produce a patch for status bar to see how 
it looks once I get home.

Comment 10

[marlon bishop]

i concur with jen's comments, we originally wanted a compact set of information.
i think tooltips would complement that fine

Comment 11

[Mike Lee]

Attachment: show email on status bar

Tell you the truth, this looks annoying at best. I like the tooltip better, and
actually make sense since personal bookmark on navigator also show tooltip for
url. Statusbar only come into play for the websites. The patch also 'looks'
better with tooltip. I'll attach the tooltip patch after this and then we can
pick one.

Comment 12

[Mike Lee]

Attachment: Show email as tooltip

as promised

Comment 13

[Mike Lee]

Any decision made on whether to use tooltip or statusbar?

Comment 14

[jglick]

Tooltip instead of status bar info would be fine with me. Ben, what are your 
thoughts?

Comment 15

[Ben Ruppel]

Tooltips all the way baby!
(err... that's a "yes")

Comment 16

[Mike Lee]

Okay, can a kind person help get this thing reviewed and stuff? I couldn't set
set the keywords for review.

Comment 17

[jglick]

*** Bug 79049 has been marked as a duplicate of this bug. ***

Comment 18

[Håkan Waara]

Comment on attachment 75547 [details] [diff] [review]
Show email as tooltip

r=hwaara

Comment 19

[Mike Lee]

Thank Håkan for the review, do we still need super review for the truck? If not
can you check it in? If so who do we ask? (I don't suppose this got a chance of
making 1.0?)

Comment 20

[Håkan Waara]

This won't make 1.0 at this point -- it's too late. Yes, you need super-review
from a mailnews super-reviewer. Try emailing: [e-mail],
[e-mail] and [e-mail] and CC [e-mail] in
your email (as per the super-review guidelines -- if you haven't read them,
please do!)

Comment 21

[Mike Lee]

I'm sure I did, but better read it again just in case. Thanks

Comment 22

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 23

[(not reading, please use [e-mail] instead)]

fix checked in the trunk.

thanks for the patch, Mike.

Comment 24

[Ben Ruppel]

Yes, thank you very much.  This will definitely be a worthwhile feature.

Comment 25

[Mike Lee]

Very cool, it seems to work in build 2002051508. Thanks everyone :)

Comment 26

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.