All users were logged out of Bugzilla on October 13th, 2018

Remove InterpreterFrames class and use InterpreterActivation instead

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

unspecified
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 788511 [details] [diff] [review]
Patch

InterpreterFrames is used to enable interrupts in js::Interpret invocations. The linked list of (interpreter) activations we now have has everything we need though, so there's no need to maintain a second list.
Attachment #788511 - Flags: review?(luke)
(Assignee)

Comment 1

5 years ago
Forgot to mention, the patch also removes InterpreterActivation::current_, we can use regs_.fp() instead.

Comment 2

5 years ago
Nice find; I forgot all about this!  Maybe I'm missing a constraint, but could InterpreterActivation just store the switchMask/value directly such that enableInterrupts could *switchMask = value directly?
(Assignee)

Comment 3

5 years ago
Created attachment 789011 [details] [diff] [review]
Patch v2

(In reply to Luke Wagner [:luke] from comment #2)
> Nice find; I forgot all about this!  Maybe I'm missing a constraint, but
> could InterpreterActivation just store the switchMask/value directly such
> that enableInterrupts could *switchMask = value directly?

Yeah that works. This patch removes the InterruptEnabler stuff as well.
Attachment #788511 - Attachment is obsolete: true
Attachment #788511 - Flags: review?(luke)
Attachment #789011 - Flags: review?(luke)

Comment 4

5 years ago
Comment on attachment 789011 [details] [diff] [review]
Patch v2

Great
Attachment #789011 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/cd086a74f522
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.