903803 - createDataChannel doesn't respect ordered in RTCDataChannelInit dict

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Kahmyong Moon]

Using "ordered: false" doesn't seem to do anything; created data channels are always ordered.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

What version are you testing, and with what code?  Can you run a Debug build (from ftp.mozilla.org) and set the env variables NSPR_LOG_MODULES=datachannel:5 NSPR_LOG_FILE=some temp file and run your test?

Comment 2

[Kahmyong Moon]

Attachment: NSPR_DEBUG_LOG with datachannel:5

Data channel log using this build:

ftp://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win32-debug/1376310819/firefox-26.0a1.en-US.win32.zip

Comment 3

[Kahmyong Moon]

Attachment: ordered.html

Simple test case showing value of ordered is being ignored.

Comment 4

[Kahmyong Moon]

I've been using Nightly for my tests (26.0a1; originally 2013-08-10, just retested with 2013-08-12, same behavior).

My code has a bunch of dependencies on a custom server, but the simple test case I attached exhibits the same behavior, where dc.ordered doesn't reflect the value passed to createDataChannel().

Additionally, while I can't come up with a simple test case to show it, I'm not seeing the SCTP unordered flag on the DATA chunks I'm receiving from Firefox.

Comment 5

[Kahmyong Moon]

Attachment: NSPR_LOG_FILE from my application

Not sure if it provides much additional information, but here's the log from my full application (same build as attachment 788965 [details]).

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Sets ordered flag correctly in DataChannel constructor

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 789143 [details] [diff] [review]
Sets ordered flag correctly in DataChannel constructor

Review of attachment 789143 [details] [diff] [review]:
-----------------------------------------------------------------

Hmmm.  Wonder how that regressed...  Thanks

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

> Hmmm.  Wonder how that regressed...  Thanks

It seems to go back the beginning http://hg.mozilla.org/mozilla-central/rev/a9ab0881ebe2

Maybe worth an uplift?

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ccbff57ff20f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ccbff57ff20f