903859 - [WiFi] setWifiEnabled tries to configure the WiFi operation mode before any driver being loaded

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Alexandre LISSY :gerard-majax]

While trying to make run B2G on HTC Desire Z, and more precisely getting WiFi to work, I came across this:

https://mxr.mozilla.org/mozilla-central/source/dom/wifi/WifiWorker.js#1228

In this code, one can see that the prepareForStartup() function calls setWifiOperationMode() prior to loading the driver in loadDriver(). The setWifiOperationMode() will obviously fail if there is no driver loaded.

Switching both, i.e., calling loadDriver() and then calling setWifiOperationMode() fixes the issue on my Desire Z.

Comment 1

[Alexandre LISSY :gerard-majax]

Vincent, can you confirm that I'm right ?

Comment 2

[Alexandre LISSY :gerard-majax]

FYI, as far as I can say and test, this does not break anything on Inari with Gecko master: WiFi still works well.

Comment 3

[Alexandre LISSY :gerard-majax]

As far as I could compare, the ndc/netd set behave differently.

Comment 4

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch for mc v1.0

We should always load the wifi driver before modifying the operation mode.

Comment 5

[Inder]

(In reply to Vincent Chang[:vchang] from comment #4)
> Created attachment 788791 [details] [diff] [review]
> Patch for mc v1.0
> 
> We should always load the wifi driver before modifying the operation mode.
This patch fixes wifi issue due to changes in bug 887485 on our reference hardware as well!

Comment 6

[Michael Wu [:mwu]]

Comment on attachment 788791 [details] [diff] [review]
Patch for mc v1.0

r=me for an obviously correct change to fix wifi bustage.

Comment 7

[Vincent Chang[:vchang][changyihsin]]

Push to inbound.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9f93acbf43a

Comment 8

[Ryan VanderMeulen [:RyanVM]]

We have a really cool tree for B2G landings now called b2g-inbound, btw :)
https://hg.mozilla.org/integration/b2g-inbound/

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 788791 [details] [diff] [review]
Patch for mc v1.0

Sorry for missing this on the first go-around.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c9f93acbf43a