903905 - currentSet should never be undefined, so add-ons don't reset the toolbar

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Hector Zhao [:hectorz]]

+++ This bug was initially created as a clone of Bug #869134 +++

In bug 868820, :dao said using currentSet property should be safe for manipulating toolbars.

One of the extensions distributed by Beijing office use navbar.currentSet to add its own toolbar button. In a recent version the none-empty check was accidentally removed, soon after which users reported to us their urlbar would disappear occasionally.

By restoring the check and collecting none-true currentSet values, it is found less than one percent of our extension users have a undefined navbar.currentSet, one second after chrome window load event.

There's no reliable STR yet, but from users' feedback, it could be related to the computer's unexpected shutting down before they boot the computer and launch Firefox.

Comment 1

[Hector Zhao [:hectorz]]

I think this is no longer relevant now that a regular extension doesn't have access to XUL currentSet property anymore.