Closed Bug 903918 Opened 10 years ago Closed 9 years ago

[Flatfish][Settings] support 2 column layout for tablet


(Firefox OS Graveyard :: Gaia::Settings, defect)

Gonk (Firefox OS)
Not set


(Not tracked)

1.3 Sprint 4 - 11/8


(Reporter: gasolin, Assigned: dwi2)



(Whiteboard: [Flatfish only][developer+])


(9 files)


Modify and Merge experiment tablet work from

to master
Blocks: flatfish
blocking-b2g: --- → koi+
Assignee: nobody → arthur.chen
Comment on attachment 791923 [details]

Currently change homescreen won't work: press the change button and nothing happens, except it will goes back to the homescreen.
(In reply to Greg Weng [:snowmantw] from comment #3)
> Created attachment 791925 [details]
> Passcode.png


Passcode seems fine at the device. See Attachment 792575 [details].
pre comment 7, I think its because we dont have another homescreen app. Maybe a bug that should disabled the change button if current is the default homescreen.
Nice to have at current stage.
blocking-b2g: koi+ → ---
It's a must for flatfish. koi+
blocking-b2g: --- → leo+
Whiteboard: [Flatfish only]
blocking-b2g: leo+ → koi+
Assignee: arthur.chen → ejchen
Flatfish only UI change, move to 1.3+.
blocking-b2g: koi+ → 1.3+
Summary: [Flatfish][Settings] add support for large device → [Flatfish][Settings] support 2 column layout for tablet
Assignee: ejchen → tzhuang
according to 10/18 meeting result, ETA date will be 11/5 (ready for review), 11/14 landed.
Target Milestone: --- → 1.3 Sprint 4 - 11/8
Depends on: 934326
Attached file pull request
Hi Arthur,
Please kindly help to review this patch, Thanks
Attachment #827810 - Flags: review?(arthur.chen)
implementation resource and ETA date are both agree with RD team. this has to be done before 1.3FC

hi arthur,

can you please kindly support this review?
Flags: needinfo?(arthur.chen)
Whiteboard: [Flatfish only] → [Flatfish only][developer+]
As there are changes of multiple tablet apps in common, we will have a meeting discussing this today. Plan to finish the review within this week.
Flags: needinfo?(arthur.chen)
Comment on attachment 827810 [details] [review]
pull request

Cancel the review at first per a offline discussion with tzu-lin. He needs some time to rebase to master.
Attachment #827810 - Flags: review?(arthur.chen)
blocking-b2g: 1.3+ → ---
Comment on attachment 827810 [details] [review]
pull request

Hi Arthur,
I've finish all rebase and clean up work, please help to review the patch.
Attachment #827810 - Flags: review?(arthur.chen)
Blocks: 943173
Comment on attachment 827810 [details] [review]
pull request

Thank you for the patch. r=me with the followup bug (removing the dup code with building block) created and green travis.
Attachment #827810 - Flags: review?(arthur.chen) → review+
The followup bug is bug 943173
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.