Closed Bug 903924 Opened 12 years ago Closed 12 years ago

[Flatfish][LockScreen] add support for large device

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Lockscreen
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: gasolin, Assigned: gweng)

References

Details

Attachments

(4 files)

LockScreen.png
881.10 KB, image/png
Details
LockScree.png
775.53 KB, image/png
Details
Patch
1.30 KB, text/html
Details
Patch_Correct
187 bytes, text/html
timdream
: review+
Details
Expect: Modify and Merge experiment tablet work from https://github.com/gaia-local/gaia to master
Blocks: flatfish
blocking-b2g: --- → koi+
Attached image LockScreen.png —
Comment on attachment 791955 [details] LockScreen.png Sorry, I attach portrait picture in landscape bug. The next one would be the correct picture.
Attached image LockScree.png —
Nice to have at current stage.
blocking-b2g: koi+ → ---
UX spec attached in bug 911673
Attached file Patch —
This patch fixed some styles for the larger device followed the spec in Bug 911673, the Attachment 801597 [details].
Attachment #805219 - Flags: review?(timdream)
Comment on attachment 805219 [details] Patch <html> <head> <meta http-equiv="Refresh" content="2; url=https://github.com/mozilla-b2g/gaia/pull/12241" /> </head> <body> Redirect to pull request #12241 </body> </html>
Attached file Patch_Correct —
Sorry for the mess above. My text editor automatically escape all characters and give me a unusable HTML file.
Attachment #805220 - Flags: review?(timdream)
Attachment #805219 - Flags: review?(timdream)
Assignee: nobody → gweng
Attachment #805220 - Flags: review?(timdream) → review+
merged in gaia-master https://github.com/mozilla-b2g/gaia/commit/cbcca1e1e41e291fc9f8a4397da768f0fe41641d thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
blocking-b2g: --- → koi?
If this is for Flatfish, why put it in 1.2?
blocking-b2g: koi? → koi+
I was not able to uplift this bug to v1.2. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1.2 git cherry-pick -x -m1 cbcca1e1e41e291fc9f8a4397da768f0fe41641d <RESOLVE MERGE CONFLICTS> git commit
Flags: needinfo?(gweng)
Hello John, I've leave the related ni in Bug 919854. The conflicts problem should be solved now.
Flags: needinfo?(gweng)
Greg, please make sure that you set flags for branch landings when you do them v1.2: https://github.com/snowmantw/gaia/commit/454fd5db165727971837cb69d550412a634ddb6c
status-b2g-v1.2: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: