904013 - [Contacts] Replace "+" Icon in contacts for 1x, 1.5x and 2x

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)

Description

[Eric Pang [:epang] UX]

Attachment: plus icon.zip

Pavel,

Doesn't look like contacts is using the right "+" icon.  Can you replace the 1x, 1.5x and 2x icons with the ones attached?  Thanks!  Since this affects the HD version I'm marking as HD

Comment 1

[Eric Pang [:epang] UX]

Attachment: Contact - Add Contact.png

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/v1.1.0hd

Comment 4

[Eric Pang [:epang] UX]

adding status-b2g-v1.1hd:? flag

Comment 5

[Sam Joch [:samjoch]]

Comment on attachment 789187 [details]
patch for Gaia/master

landed in master: https://github.com/mozilla-b2g/gaia/commit/979b5e544b11f378a1d1c25454ce58c7e446b7e4

Comment 6

[Sam Joch [:samjoch]]

Pavel same here, when the HD flag is high, you will be able to cherry-pick the patch.

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Landed in v1.1.0hd:
https://github.com/mozilla-b2g/gaia/commit/b6b66e976692b1c590d19e2d9c68d43fb5aed9f4

Comment 8

[Eric Pang [:epang] UX]

Hey Pavel, since this has landed can you update status-b2g-v1.1hd:? to fixed? Thanks!

Comment 9

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Nope I think we need first `affected`.

Comment 10

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #9)
> Nope I think we need first `affected`.

Sam, is it okay if we changed it fixed when the patches land since the bugs are HD+?  Correct me if I'm mistaken! Thanks!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Set the status to fixed when the patch is uplifted.

Comment 12

[Eric Pang [:epang] UX]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #11)
> Set the status to fixed when the patch is uplifted.

Thanks Ryan!

Comment 13

[Sam Joch [:samjoch]]

Oops i was confused about the last comment and i (re)commit base on the master commit: https://github.com/mozilla-b2g/gaia/commit/dc09f6fb5c0dd815e0be87e70a7475373c7b5b0e

Pavel, I test on the device, and it was ok. Can you confirm ?
If this is not good, i will revert that commit.

By the way i think we should only review one patch and cherry-pick with correcting the conflicts if its needed in the another branch.

Comment 14

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I confirm.

Sure we can r+ only the master and then cherry pick or just merge the patch for v1.1.0hd

Comment 15

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #14)
> I confirm.
> 
> Sure we can r+ only the master and then cherry pick or just merge the patch
> for v1.1.0hd

Hey Pavel, has this landed in HD?  Amy noticed that the wrong size icons seems to still be showing up.

Comment 16

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Landed on v1.1.0hd:
https://github.com/mozilla-b2g/gaia/commit/b6b66e976692b1c590d19e2d9c68d43fb5aed9f4

Comment 17

[Eric Pang [:epang] UX]

(In reply to Pavel Ivanov [:ivanovpavel] from comment #16)
> Landed on v1.1.0hd:
> https://github.com/mozilla-b2g/gaia/commit/
> b6b66e976692b1c590d19e2d9c68d43fb5aed9f4

thanks Pavel!

Comment 18

[William Hsu [:whsu]]

Hi, all,

Thanks for your help!
Verify the change.

* Test Build:
 - Gaia:     7859b08b221463e0c5559034ab151747af6eb038
 - Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/8c326236a729
 - BuildID   20130924042203
 - Version   18.0

Attaching the screenshot.

Comment 19

[William Hsu [:whsu]]

Attachment: ContactApp - Add icon