Closed Bug 904027 Opened 6 years ago Closed 6 years ago

[HD][Music] Video scrubber edges looks slightly fuzzy

Categories

(Firefox OS Graveyard :: Gaia::Music, defect, P3)

All
Other
defect

Tracking

(blocking-b2g:hd+, b2g-v1.1hd fixed)

VERIFIED FIXED
blocking-b2g hd+
Tracking Status
b2g-v1.1hd --- fixed

People

(Reporter: epang, Assigned: pivanov)

Details

(Whiteboard: helix vsd, HD)

Attachments

(5 files, 1 obsolete file)

Attached image Music - Scrubber.png (obsolete) —
Pavel, can you check if the graphics are the correct size for the scrubber?  It appears to be fuzzy.  I've attached the icons in case for updating, if they are different.  Thanks!
Attached file Scrubber icons
adding status-b2g-v1.1hd:? flag
Hey Eric,
the scrubber image and size are ok, but for the pressed state we use border, here is the comment from the source code:

/* background-image does not support transition
   * so here we use background-color and border on a div
   * to draw an image just like
   * url("./images/scrubber_pressed.png")
   * that image is also committed
   * if UX wants to use the original image
   */

If we want to skip the transition I can do this but otherwise I can't do much on this. Ideas?
Flags: needinfo?(epang)
Attached file Music Scrubber Icons
Pavel, is it possible to try out these icons without the transition?  But if it's not a improvement then revert?
Attachment #788884 - Attachment is obsolete: true
Flags: needinfo?(epang)
Sure, I can create a patch for SD and you can test it on your device (without transition) and if you are OK I can create a patch for HD too?
Flags: needinfo?(epang)
sounds good!
Flags: needinfo?(epang)
Attached file patch for Gaia/master
I think it looks ok :)
Attachment #790384 - Flags: feedback?(epang)
HD+ asset
blocking-b2g: hd? → hd+
Comment on attachment 790384 [details]
patch for Gaia/master

Yes, I agree this looks good. Thanks!
Attachment #790384 - Flags: feedback?(epang) → feedback+
Attachment #790926 - Flags: review?(sjochimek)
Attachment #790384 - Flags: review?(sjochimek)
Attachment #790928 - Attachment mime type: text/html → image/png
Comment on attachment 790926 [details]
patch for Gaia/v1.1.0hd

Remove the flag since this is the same patch as master.
Please ask for review just once on master, 
then we'll figure out a way to cherry-pick in v1.1.0hd if it's flagged hd as well, thanks.
Attachment #790926 - Flags: review?(sjochimek)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: helix vsd → helix vsd, HD
http://www.youtube.com/watch?v=AaWFxoaM0Xo
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.