904027 - [HD][Music] Video scrubber edges looks slightly fuzzy

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P3)

Description

[Eric Pang [:epang] UX]

Attachment: Music - Scrubber.png

Pavel, can you check if the graphics are the correct size for the scrubber?  It appears to be fuzzy.  I've attached the icons in case for updating, if they are different.  Thanks!

Comment 1

[Eric Pang [:epang] UX]

Attachment: Scrubber icons

Comment 2

[Eric Pang [:epang] UX]

adding status-b2g-v1.1hd:? flag

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Eric,
the scrubber image and size are ok, but for the pressed state we use border, here is the comment from the source code:

/* background-image does not support transition
   * so here we use background-color and border on a div
   * to draw an image just like
   * url("./images/scrubber_pressed.png")
   * that image is also committed
   * if UX wants to use the original image
   */

If we want to skip the transition I can do this but otherwise I can't do much on this. Ideas?

Comment 4

[Eric Pang [:epang] UX]

Attachment: Music Scrubber Icons

Pavel, is it possible to try out these icons without the transition?  But if it's not a improvement then revert?

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Sure, I can create a patch for SD and you can test it on your device (without transition) and if you are OK I can create a patch for HD too?

Comment 6

[Eric Pang [:epang] UX]

sounds good!

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

I think it looks ok :)

Comment 8

[Wayne Chang [:wchang]]

HD+ asset

Comment 9

[Eric Pang [:epang] UX]

Comment on attachment 790384 [details]
patch for Gaia/master

Yes, I agree this looks good. Thanks!

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/v1.1.0hd

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot

Comment 12

[Sam Joch [:samjoch]]

Comment on attachment 790926 [details]
patch for Gaia/v1.1.0hd

Remove the flag since this is the same patch as master.
Please ask for review just once on master, 
then we'll figure out a way to cherry-pick in v1.1.0hd if it's flagged hd as well, thanks.

Comment 13

[Sam Joch [:samjoch]]

Comment on attachment 790384 [details]
patch for Gaia/master

Nice one!

Landed in master: https://github.com/mozilla-b2g/gaia/commit/fe1880bf378412d78a8c57c07208a8ed61dc5a00

Landed in v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/93d85669fb3ee1f815b7113cfe8e661770dccda3

Comment 14

[Al Tsai [:atsai]]

http://www.youtube.com/watch?v=AaWFxoaM0Xo