904075 - Regression: Unable to invoke a context menu on media source elements -- JS Error: mediaSrc is not defined

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

E/GeckoConsole(13074): [JavaScript Error: "ReferenceError: mediaSrc is not defined" {file: "chrome://browser/content/browser.js" line: 7624}]

http://cd.pn/b; long-tap on the video

--
Nightly (08/12) | LG Nexus 4 (Android 4.3)

Comment 1

[Aaron Train [:aaronmt]]

Regression from bug 818987?

Comment 2

[Wesley Johnston (:wesj)]

Attachment: mediaSrc

Grr. Missed this in my last review.

Comment 3

[:Margaret Leibovic]

Comment on attachment 789159 [details] [diff] [review]
mediaSrc

Review of attachment 789159 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/browser.js
@@ +7631,5 @@
>    // extend _getLink to pickup html5 media links.
>    _getMediaLink: function(aElement) {
>      let uri = NativeWindow.contextmenus._getLink(aElement);
>      if (uri == null) {
> +      if (aElement.nodeType == Ci.nsIDOMNode.ELEMENT_NODE && (aElement instanceof Ci.nsIDOMHTMLMediaElement)) {

Could you combine this with the (uri == null) check above? It feels odd to have an if statement that only contains another if statement.

Also, you can get rid of the inner parens, now that you're not combining the instanceof check with a && check.

Comment 5

[Wesley Johnston (:wesj)]

Grr. forgot there was a comment here. I'll push a follow up for it because its a good idea.

https://hg.mozilla.org/integration/fx-team/rev/507578ef9f8b

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/94369a32a3ac

Comment 7

[Teodora Vermesan (:TeoVermesan)]

The regression window is:

1.mozilla-central
good build: 08.08.2013 
bad build: 09.08.2013 
-pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fd4cf30428b0&tochange=e33c2011643e

2.inbound
good build:1376090740
bad build: 1376091041
-pushlog: 
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2904a317c74b&tochange=0c2ce8aaa005

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/507578ef9f8b
https://hg.mozilla.org/mozilla-central/rev/94369a32a3ac