904084 - [b2g-voicemail] Marionette tests fail for mozVoicemail API on the emulator

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[José Antonio Olivera Ortega [:jaoo]]

Attachment: voicemail-error.txt

While working on bug 888593 (Move MozVoicemail to WebIDL) I've noticed the marionette tests for mozVoicemail API on the emulator are failing.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

See also bug 806138.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Bug 834160 renames nsIRILVoicemailCallback::voicemailNotification to nsIVoicemailListener::notifyStatusChanged, but RILContentHelper was not updated accordingly.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: patch

1) Use |SpecialPowers.Cu| instead.
2) s/voicemailNotification/notifyStatusChanged/ in RILContentHelper.js

https://tbpl.mozilla.org/?tree=Try&rev=960012c31aab

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #3)
> Created attachment 789509 [details] [diff] [review]
> patch
> 
> 1) Use |SpecialPowers.Cu| instead.
> 2) s/voicemailNotification/notifyStatusChanged/ in RILContentHelper.js

Thanks for taking care of this. Once this patch get landed I'll request review for bug 888593. Does bug 888593 need a RIL peer review? Thanks!

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

(In reply to José Antonio Olivera Ortega [:jaoo] (PTO August 19th till Sept 2nd) from comment #4)
> Thanks for taking care of this. Once this patch get landed I'll request
> review for bug 888593. Does bug 888593 need a RIL peer review? Thanks!

Probably not, but we'll still have a check offlinely.  Thank you for the job!

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/333d778a0619

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/333d778a0619