Closed Bug 904084 Opened 9 years ago Closed 9 years ago

[b2g-voicemail] Marionette tests fail for mozVoicemail API on the emulator

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jaoo, Assigned: vicamo)

References

Details

Attachments

(2 files)

Attached file voicemail-error.txt
While working on bug 888593 (Move MozVoicemail to WebIDL) I've noticed the marionette tests for mozVoicemail API on the emulator are failing.
Summary: [ b2g-voicemail] Marionette tests fails for mozVoicemail API on the emulator → [b2g-voicemail] Marionette tests fail for mozVoicemail API on the emulator
Assignee: nobody → vyang
See also bug 806138.
Bug 834160 renames nsIRILVoicemailCallback::voicemailNotification to nsIVoicemailListener::notifyStatusChanged, but RILContentHelper was not updated accordingly.
Depends on: 834160
Attached patch patchSplinter Review
1) Use |SpecialPowers.Cu| instead.
2) s/voicemailNotification/notifyStatusChanged/ in RILContentHelper.js

https://tbpl.mozilla.org/?tree=Try&rev=960012c31aab
Attachment #789509 - Flags: review?(allstars.chh)
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #3)
> Created attachment 789509 [details] [diff] [review]
> patch
> 
> 1) Use |SpecialPowers.Cu| instead.
> 2) s/voicemailNotification/notifyStatusChanged/ in RILContentHelper.js

Thanks for taking care of this. Once this patch get landed I'll request review for bug 888593. Does bug 888593 need a RIL peer review? Thanks!
Attachment #789509 - Flags: review?(allstars.chh) → review+
(In reply to José Antonio Olivera Ortega [:jaoo] (PTO August 19th till Sept 2nd) from comment #4)
> Thanks for taking care of this. Once this patch get landed I'll request
> review for bug 888593. Does bug 888593 need a RIL peer review? Thanks!

Probably not, but we'll still have a check offlinely.  Thank you for the job!
https://hg.mozilla.org/mozilla-central/rev/333d778a0619
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.