Closed
Bug 904120
Opened 8 years ago
Closed 8 years ago
Popcorn pages are no longer using media queries in the published page
Categories
(Webmaker Graveyard :: Make Valet, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: thecount, Assigned: jon)
Details
Attachments
(1 file)
Make valet just pushed up a page that changed the way details was rednered. It broke the media queries. Instead of displaying it a set number of screen resolutions, It is filling the page. This means track events position might not be correct. We should back out the make valet changes, add in another fix that adds the media queries to the backed out page. This highlights a bunch of recent discussion I've had to remove the media queries and make popcorn work dynamically in all sizes.
|
Reporter | |
Updated•8 years ago
|
Assignee: nobody → jon
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #789057 -
Flags: review?(scott)
Attachment #789057 -
Flags: review?(kate)
|
|
Reporter | |
Updated•8 years ago
|
Attachment #789057 -
Flags: review?(scott) → review+
|
||
Comment 2•8 years ago
|
||
Commits pushed to master at https://github.com/mozilla/make-valet https://github.com/mozilla/make-valet/commit/9c5b61ae2d41b17e91736e81adfb223dbd766e7e Bug 904120 - Container should be generically named https://github.com/mozilla/make-valet/commit/882fee697794d4932a420134d3a28a71840fb44c Bug 904120 - Use Popcorn media query embed sizes
|
|
Assignee | |
Updated•8 years ago
|
Attachment #789057 -
Flags: review?(kate)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Building on staging now
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•8 years ago
|
||
Verified: https://jon.mywebmaker.org/popcorn/14fw
Status: RESOLVED → VERIFIED
|
||
Updated•8 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•