Closed
Bug 904126
Opened 11 years ago
Closed 11 years ago
Permanent Orange (comm-beta only): TEST-UNEXPECTED-FAIL | test_filtering.js | Test timed out
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Unassigned)
References
Details
(Keywords: intermittent-failure, Whiteboard: [fixed by bug 904263])
Attachments
(1 file)
751 bytes,
patch
|
Details | Diff | Splinter Review |
We've been seeing this on comm-beta (only) since the aurora -> beta merge. It did not happen before the merge, nor did it happen after the merge. Happens on all platforms and both opt and debug builds. Typical logs: https://tbpl.mozilla.org/php/getParsedLog.php?id=26440723&tree=Thunderbird-Beta#error0 TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/chat/modules/test/test_filtering.js | Test timed out TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/chat/modules/test/test_filtering.js | test failed (with xpcshell return code: -6), see following log: >>>>>>> ... TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/chat/modules/test/test_filtering.js | [test_standardMode : 152] "<span style="-moz-text-decoration-line: underline;">foo</span>" == "<span style="-moz-text-decoration-line: underline;">foo</span>" TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/chat/modules/test/test_filtering.js | [test_standardMode : 164] "<span style="">foo</span>" == "<span style="">foo</span>" TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/chat/modules/test/test_filtering.js | [test_standardMode : 164] "<span style="">foo</span>" == "<span style="">foo</span>" TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/chat/modules/test/test_filtering.js | [test_standardMode : 164] "<span style="">foo</span>" == "<span style="">foo</span>" TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/chat/modules/test/test_filtering.js | [test_standardMode : 164] "<span style="">foo</span>" == "<span style="">foo</span>" TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/chat/modules/test/test_filtering.js | [test_standardMode : 164] "<span style="">foo</span>" == "<span style="">foo</span>" TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/chat/modules/test/test_filtering.js | [test_standardMode : 164] "<span style="">foo</span>" == "<span style="">foo</span>" <<<<<<< (then follows the crash log of the interrupted process)
Reporter | ||
Comment 1•11 years ago
|
||
This hangs for me locally as well with 100% CPU. Doing this is a work-around to make it pass: diff --git a/chat/modules/test/test_filtering.js b/chat/modules/test/test_filtering.js --- a/chat/modules/test/test_filtering.js +++ b/chat/modules/test/test_filtering.js @@ -165,8 +165,8 @@ function test_standardMode() { } // The shorthand 'font' is decomposed to non-shorthand properties, // and not recomposed as some non-shorthand properties are filtered out. - do_check_eq("<span style=\"font-style: normal; font-weight: normal;\">foo</span>", - cleanupImMarkup("<span style=\"font: 15px normal\">foo</span>")); +// do_check_eq("<span style=\"font-style: normal; font-weight: normal;\">foo</span>", +// cleanupImMarkup("<span style=\"font: 15px normal\">foo</span>")); run_next_test(); } @@ -217,9 +217,9 @@ function test_permissiveMode() { } // The shorthand 'font' is decomposed to non-shorthand properties, // and not recomposed as some non-shorthand properties are filtered out. - do_check_eq("<span style=\"font-family: normal; font-style: normal;" + - " font-weight: normal; font-size: 15px;\">foo</span>", - cleanupImMarkup("<span style=\"font: 15px normal\">foo</span>")); +// do_check_eq("<span style=\"font-family: normal; font-style: normal;" + +// " font-weight: normal; font-size: 15px;\">foo</span>", +// cleanupImMarkup("<span style=\"font: 15px normal\">foo</span>")); // text-decoration is a shorthand for several -moz-text-decoration properties. do_check_eq("<span style=\"-moz-text-decoration-color: -moz-use-text-color;" + " -moz-text-decoration-line: underline;" +
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment 14•11 years ago
|
||
I filed bug 904126 on what I think the real issue is, and I'm attaching a workaround that I think is correct anyway (removeProperty returns an empty string if the property wasn't found, or the value that the removed property had; but I don't think a property has a valid reason to be listed if it has an empty value, so the null check I'm adding should only detect the failure we are seeing here).
Comment 15•11 years ago
|
||
(In reply to Florian Quèze [:florian] [:flo] from comment #14) > I filed bug 904126 on what I think the real issue is I meant bug 904263.
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Comment 19•11 years ago
|
||
This was fixed by bug 904263
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 904263]
You need to log in
before you can comment on or make changes to this bug.
Description
•