TEST-UNEXPECTED-FAIL | test-send-button.js | test-send-button.js::test_send_enabled_address_contacts_sidebar

RESOLVED FIXED

Status

Thunderbird
Address Book
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: standard8, Assigned: aceman)

Tracking

({intermittent-failure})

Trunk
All
Mac OS X
intermittent-failure

Thunderbird Tracking Flags

(thunderbird_esr2425+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
I believe this has only been seen on Mac so far:

https://tbpl.mozilla.org/php/getParsedLog.php?id=26441739&tree=Thunderbird-Beta#error0

SUMMARY-UNEXPECTED-FAIL | test-send-button.js | test-send-button.js::test_send_enabled_address_contacts_sidebar
  EXCEPTION: a != b: 'true' != 'false'.
    at: test-folder-display-helpers.js line 2817
       assert_true test-folder-display-helpers.js 2817
       assert_equals test-folder-display-helpers.js 2804
       check_send_commands_state test-send-button.js 47
       test_send_enabled_address_contacts_sidebar test-send-button.js 128
       Runner.prototype.wrapper frame.js 582
       Runner.prototype._runTestModule frame.js 652
       Runner.prototype.runTestModule frame.js 698
       Runner.prototype.runTestDirectory frame.js 522
       runTestDirectory frame.js 704
       Bridge.prototype._execFunction server.js 179
       Bridge.prototype.execFunction server.js 183
Comment hidden (Treeherder Robot)
(Assignee)

Comment 2

5 years ago
JavaScript error: chrome://messenger/content/addressbook/abContactsPanel.js, line 39: cards is null

We tried to fix this one in bug 826732. Are those patches in the TB-beta tree you are looking at?
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 11

5 years ago
Comment 2.
Flags: needinfo?(mbanner)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Reporter)

Comment 17

5 years ago
(In reply to :aceman from comment #2)
> JavaScript error: chrome://messenger/content/addressbook/abContactsPanel.js,
> line 39: cards is null
> 
> We tried to fix this one in bug 826732. Are those patches in the TB-beta
> tree you are looking at?

You're right, that doesn't seem to be there. Could you extract the relevant part of attachment 767889 [details] [diff] [review] and we'll get it landed on the 24 branch for tidying up oranges there over the next year.
tracking-thunderbird24: --- → +
Flags: needinfo?(mbanner)
(Assignee)

Comment 18

5 years ago
Created attachment 803227 [details] [diff] [review]
patch

I think this is the relevant part.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #803227 - Flags: review?(mbanner)
(Reporter)

Comment 19

5 years ago
Comment on attachment 803227 [details] [diff] [review]
patch

Yeah, That seems to be the one. We'll get this landed on the right channels once things settle down a bit.
Attachment #803227 - Flags: review?(mbanner)
Attachment #803227 - Flags: review+
Attachment #803227 - Flags: approval-comm-esr24?
(Reporter)

Comment 20

5 years ago
Comment on attachment 803227 [details] [diff] [review]
patch

[Triage Comment]
Lets get this on comm-esr24 as well, as we have the failures there.
Attachment #803227 - Flags: approval-comm-esr24? → approval-comm-esr24+
(Reporter)

Comment 21

5 years ago
https://hg.mozilla.org/releases/comm-esr24/rev/dfaec501b9b1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-thunderbird_esr24: --- → fixed
tracking-thunderbird24: + → ---
tracking-thunderbird_esr24: --- → 25+
Resolution: --- → FIXED
Comment hidden (Treeherder Robot)
You need to log in before you can comment on or make changes to this bug.