Closed Bug 904148 Opened 6 years ago Closed 6 years ago

jsstr.cpp:1937:8: warning: 'ReplaceData' has a field 'ReplaceData::g ' whose type uses the anonymous namespace [enabled by default]

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

New build warning, in my local linux mozilla-central build with GCC 4.8:
{
js/src/jsstr.cpp:1937:8: warning: 'ReplaceData' has a field 'ReplaceData::g
' whose type uses the anonymous namespace [enabled by default]
}

Bug 888280 moved g's type (StringRegExpGuard) into an anonymous namespace; while ReplaceData struct isn't namespaced.

The obvious fixes would be to either (a) un-namespace StringRegExpGuard, or (b) put ReplaceData into the anonymous namespace.

I'm assuming (b) would be preferred.
Attached patch fix v1Splinter Review
Attachment #789047 - Flags: review?(jwalden+bmo)
Assignee: general → dholbert
Status: NEW → ASSIGNED
Attachment #789047 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/12e7e6c547b9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.