904157 - Remove restrictions to region exclusions for paid apps

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P2)

Description

[Stuart Colville [:muffinresearch]]

Currently we are restricting region exclusions for paid apps down to regions that are relevant to the price point selected.

This causes problems.

For example if payments are turned off for a region temporarily the user could currently go into devhub save the payment details and then create an exclusion record for that region. Once it's re-enabled they would then have their app excluded even if they didn't previously.

The solution is to show all regions regardless (possibly separated by those that have payments and those that don't)

If payments are not available for the price point, this will be shown in the UI. 

Always the developer will be able to set *any* of the regions for paid apps. This then de-couples regions (as relate to addonExcludedRegion records) from price region data.

Comment 1

[Wil Clouser [:clouserw]]

This doesn't seem like a high priority, but interested in your input.  What's the priority/status?

Comment 2

[Stuart Colville [:muffinresearch]]

This is necessary to prevent a lot of pain in terms of managing the relationship between region exclusions for the apps as well as regions for payments.

Whilst the immediate impact to end-users is not much presently getting this done sooner rather than later is preferable and the fix is already quite fair along. So I'd put this as more a p3 for that reason.

Comment 3

[Stuart Colville [:muffinresearch]]

Making this P2 as per the dep bugs.

Comment 4

[Stuart Colville [:muffinresearch]]

Removing the milestone due to the deps. I'll keep this branch up to date so it doesn't bit-rot for when we are ready.

Comment 5

[Stuart Colville [:muffinresearch]]

Still needs reworking animations over to transitions.

Comment 7

[Stuart Colville [:muffinresearch]]

(In reply to Stuart Colville [:scolville] from comment #5)
> Still needs reworking animations over to transitions.

Going to look at this separately.

Comment 8

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/zamboni/commit/1bb5a3816b34728487686721cee6775fe4d76d63

Comment 9

[Stuart Colville [:muffinresearch]]

Extra QA Notes:

This changes a lot of code around the devhub for region selection for both free and paid apps. Please make sure everything is working as expected.

Suggested areas to check (but not limited to):

* App region selection.
* Conversion between free and paid apps.
* Enable new regions checkbox.
* Selection of prices (see the animations of checkboxes so the user knows which apps are associated with which regions).

This de-restricts region choices for paid so checking how this is displayed (code to filter apps in search has already landed separately).