904180 - Fully back out all changes from Bug 748894 - menubutton-dropmarker

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[Elbart]

Bug 867343 was meant to revert all changes from Bug 748894 for non-Australis-builds, but the changes regarding the menubutton-dropmarker area of https://bugzilla.mozilla.org/show_bug.cgi?id=748894#c65 (rev 4002c6963c4e) were left in.

The attachment shows the difference between Firefox 22 and 23 when "Small icons" is selected in the Customize-dialog.
The dropmarker-area is bigger than the other part of the button.

Comment 1

[Elbart]

Attachment: Menu-buttons in Firefox 22 and 23

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Given bug 748894 comment 81, I think this is wontfix (we're going to get rid of this button soon anyhow).

Comment 3

[Elbart]

I consider this WONTFIX as unwarranted. While the redesign of the menu-button may be reasonable in the context of Australis, any changes to it for the pre-Australis UI is unreasonable. The current UI will be in the Firefox-codebase until September 2014, when 24ESR will be EOL.

Also, this bug is proof that the backout of 748894 was not done properly. This may have other unforeseen and yet undiscovered consequences.

Please review this decision.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

As Mike and Marco mentions in their comments, this was done intentionally, and wasn't the result of an improper backout.

Comment 5

[Elbart]

As I understand the discussion in bug748894, the change for the dropmarker-area was done in combination with moving the bookmark-star out of the location-bar.
But the bookmark-star-change was reverted, that's why the change of the dropmarker-area should be backed out, too.

The initial reason for the larger dropmarker-area given in  Alice0775 White's comment ( bug748894#c54 ) only applied to the new bookmark-widget, which does not exist in non-Australis-builds. So leaving the Australis-oriented changes for the dropmarker in, but not the new widget/button-style, is a regression.