"noSuchActor" error has no message

RESOLVED FIXED in Firefox 26

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: benvie, Assigned: andreio)

Tracking

Trunk
Firefox 26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js] )

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The "noSuchActor" error packet in `DebuggerServerConnection.prototype.onPacket` has no error message. This makes debugging harder because you have to drill down to look at the packets to see the cause, rather than having a useful message reported in the console.
(Reporter)

Updated

5 years ago
Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js]
(Reporter)

Updated

5 years ago
Assignee: nobody → andrei.br92
(Assignee)

Comment 1

5 years ago
Created attachment 791235 [details] [diff] [review]
bug904201.noSuchActorErrorMsg

You mentioned that there could be multiple causes for this error => multiple error messages. Where could I look for more info ? Thanks
Attachment #791235 - Flags: feedback?(bbenvie)
(Reporter)

Comment 2

5 years ago
Comment on attachment 791235 [details] [diff] [review]
bug904201.noSuchActorErrorMsg

There can be multiple causes, but that doesn't really matter. All the error needs to do is explain what's happening. I think the message you've added does that well enough!
Attachment #791235 - Flags: feedback?(bbenvie) → feedback+
(Assignee)

Comment 3

5 years ago
Thanks. Is there anything else I need to take care of ?
(Reporter)

Comment 4

5 years ago
Nope! Thanks.
(Reporter)

Updated

5 years ago
Attachment #791235 - Flags: feedback+ → review+
(Reporter)

Comment 6

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/a2bc0c4ab5bd
Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js] → [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js] [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a2bc0c4ab5bd
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js] [fixed-in-fx-team] → [good-first-bug] [mentor=bbenvie@mozilla.com] [lang=js]
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.