Closed
Bug 904212
Opened 11 years ago
Closed 11 years ago
Remove obsolete Profiler localization strings
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: anton, Assigned: anton)
Details
Assignee | ||
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Comment 1•11 years ago
|
||
Flod, can you look into this? There seem to be potential for a bunch of obsolete strings.
Comment 2•11 years ago
|
||
Sure, I'll have a look into it today.
Comment 3•11 years ago
|
||
Unless I'm missing something obvious, these are all unused strings, the only references in the code are the strings themselves. Not used from profiler.dtd <!ENTITY profilerNew.label "New"> <!ENTITY profilerStart.label "Start"> <!ENTITY profilerStop.label "Stop"> Not used from profiler.properties profiler.startProfiling=Click here %S to start profiling profiler.stopProfiling = Click here %S to stop profiling profiler.alreadyRunning=Profiler is already running. If you want to run this profile stop Profile %S first. I tried removing them in my local nightly and the profiler runs normally.
Assignee | ||
Comment 4•11 years ago
|
||
Yeah we removed all the UI that used these strings (and this is what this bug is about). Do you have a patch ready? Otherwise, I can just remove and land the change myself real quick. Thanks for your help!
Comment 5•11 years ago
|
||
(In reply to Anton Kovalyov (:anton) from comment #4) > Yeah we removed all the UI that used these strings (and this is what this > bug is about). Do you have a patch ready? Otherwise, I can just remove and > land the change myself real quick. No patch available, please go on :-)
Assignee | ||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e87b2236f29b
Whiteboard: [fixed-in-fx-team]
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e87b2236f29b
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•