904313 - [CONTACTS] Can't import vCard when contact count > 2500

Status: RESOLVED DUPLICATE of bug 904973

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Leo]

1. Title: Can't import vCard when contact count > 2500
2. Precondition:  Save vCard with more than 2500 contacts in SD Card.
3. Tester's Action:  Contacts > Settings > SD card
4. Detailed Symptom (ENG.): Progress stuck on "Reading from SD card..." or Contacts App. is killed.
5. Expected:  The phone should not occur abnormally.(Need to place a hard limit on the number of contacts)
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced
8. Gaia Revision:   c5e8358d753b8954de7b1a8c3e00944617aeec5e
9. Personal email id: [e-mail]

Comment 1

[Leo]

This is a leo quality issue. Please check it.

Comment 2

[Wayne Chang [:wchang]]

Can QA try to reproduce this?

Leo can you provide any available logs you have or zip up the contacts you used to perform this test?

Alberto, can you check this bug here?

Comment 3

[:gerard-majax]

Looks like i'm reproducing, so looking into this.

Comment 4

[:gerard-majax]

Looks like the VCFReader is not very happy starting aroung 930 entries on my test case.

Comment 5

[:gerard-majax]

From what I see, even a 1000 entries file does not get read. It's getting blocked while filling in the rawContacts array.

Moving away the parseSingleEntry() call to the rawContacts.forEach() callback, I achieve inserting 305 contacts from this 1000 entries file.

Comment 6

[:gerard-majax]

Sergi is re-taking this one. As far as I could explore, the code somehow blocks while parsing the VCF file, in my case inside a splitLines() call.

Comment 7

[Alex Keybl [:akeybl]]

Is Leo actually going to pick this up? Back Leo nom until that's clear.

Comment 8

[Deepa Subramanian]

Attachment: logcat

I was able to repro this defect.

Had more than 2500 v-card contacts. The user is able to see "Reading from SD card..." screen while trying to import contacts from SD card.

Environmental Variables
Leo Build ID: 20130822041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/74914b454b88
Gaia: a83c5fee49525ec0545059b5a56a3fd9f1c09f19
Platform Version: 18.1

Comment 9

[David Scravaglieri [:scravag]]

As import is a leo feature it seems we should block.

Comment 10

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Progress on this can be seen at https://github.com/comoyo/gaia/compare/vcard_streaming_noworker

It would be helpful if people having the problem start using it for testing. There is a second version using workers, but probably it will not be necessary.

Comment 11

[Hubert Figuiere [:hub]]

bug 905656 might just be a dupe of this. Setting as blocked for now.

I have a 20000 entries sample.

Comment 12

[Dietrich Ayala (:dietrich)]

(In reply to David Scravaglieri [:scravag] from comment #9)
> As import is a leo feature it seems we should block.

Like Alex said in comment #7, before we can block we need answer from Leo about whether or not they'll take such a large change to contacts parser this late

Also, what the number of contacts imported should be supported. 500? 1000? 5000? 20,000?

Comment 13

[Leo]

The large change of code could not be taken to leo device now.
After get a patch, we discuss it to take in leo or not.
Regarding comment 8, the log file has already uploaded.

Comment 14

[bhavana bajaj [:bajaj]]

(In reply to Leo from comment #13)
> The large change of code could not be taken to leo device now.
Hence this does not sound like a blocker.
> After get a patch, we discuss it to take in leo or not.
> Regarding comment 8, the log file has already uploaded.

Still waiting to hear back on the number of contacts that should be supported like asked in comment #12.

Feel free to renom if needed.

Comment 15

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

I can make the code change quite smaller at the expense of some speed, but it won't be slower than it is now. I'll propose another patch. Is there a time deadline for it? I am officially on holidays, but I cna put some time on this.

Comment 16

[Mike Lee [:mlee]]

FxOs-Perf Triage: Leaving this for Contacts team to decide whether to koi+

Comment 17

[David Scravaglieri [:scravag]]

This bug need a fix in koi, failing with 305 contact looks definitely bad

Comment 18

[Joe Cheng [:jcheng] (please needinfo)]

Sergi, are you still working on this? thanks

Comment 19

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Yes, this bug is being handled in issue https://bugzilla.mozilla.org/show_bug.cgi?id=904973.