904329 - Build failures with REBUILD_CHECK=1

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

For example:
 8:35.21 Traceback (most recent call last):
 8:35.21   File "/hmozilla-central/config/rebuild_check.py", line 30, in <module>
 8:35.21     rebuild_check(sys.argv[1:])
 8:35.21   File "/hmozilla-central/config/rebuild_check.py", line 20, in rebuild_check
 8:35.21     if mtime(dep) > t:
 8:35.21   File "/mozilla-central/config/rebuild_check.py", line 8, in mtime
 8:35.21     return os.stat(path).st_mtime
 8:35.21 OSError: [Errno 2] No such file or directory: '/mozilla-central/parser/htmlparser/src/nsDTDUtils.h'

Comment 1

[Mike Hommey [:glandium]]

Attachment: Fix rebuild_check.py when files are removed

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 789343 [details] [diff] [review]
Fix rebuild_check.py when files are removed

Review of attachment 789343 [details] [diff] [review]:
-----------------------------------------------------------------

Do you think it's fair for me to ask you to rewrite this to only use a single stat() system call during the dependency file loop? It's just I imagine I'll be using this a lot and at the scale of our build system, we're looking at a few million redundant system calls.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Fix rebuild_check.py when files are removed

Fair enough, here you are.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 789437 [details] [diff] [review]
Fix rebuild_check.py when files are removed

Review of attachment 789437 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for address my (probably premature) perf concerns.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0e91dc91caf1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0e91dc91caf1