Build failures with REBUILD_CHECK=1

RESOLVED FIXED in mozilla26

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

24 Branch
mozilla26
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
For example:
 8:35.21 Traceback (most recent call last):
 8:35.21   File "/hmozilla-central/config/rebuild_check.py", line 30, in <module>
 8:35.21     rebuild_check(sys.argv[1:])
 8:35.21   File "/hmozilla-central/config/rebuild_check.py", line 20, in rebuild_check
 8:35.21     if mtime(dep) > t:
 8:35.21   File "/mozilla-central/config/rebuild_check.py", line 8, in mtime
 8:35.21     return os.stat(path).st_mtime
 8:35.21 OSError: [Errno 2] No such file or directory: '/mozilla-central/parser/htmlparser/src/nsDTDUtils.h'
(Assignee)

Comment 1

5 years ago
Created attachment 789343 [details] [diff] [review]
Fix rebuild_check.py when files are removed
Attachment #789343 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla

Comment 2

5 years ago
Comment on attachment 789343 [details] [diff] [review]
Fix rebuild_check.py when files are removed

Review of attachment 789343 [details] [diff] [review]:
-----------------------------------------------------------------

Do you think it's fair for me to ask you to rewrite this to only use a single stat() system call during the dependency file loop? It's just I imagine I'll be using this a lot and at the scale of our build system, we're looking at a few million redundant system calls.
(Assignee)

Comment 3

5 years ago
Created attachment 789437 [details] [diff] [review]
Fix rebuild_check.py when files are removed

Fair enough, here you are.
Attachment #789437 - Flags: review?(gps)
(Assignee)

Updated

5 years ago
Attachment #789343 - Attachment is obsolete: true
Attachment #789343 - Flags: review?(gps)

Comment 4

5 years ago
Comment on attachment 789437 [details] [diff] [review]
Fix rebuild_check.py when files are removed

Review of attachment 789437 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for address my (probably premature) perf concerns.
Attachment #789437 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/0e91dc91caf1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.