[binary data] Re-enable Binary Data

RESOLVED DUPLICATE of bug 898347

Status

()

Core
JavaScript Engine
RESOLVED DUPLICATE of bug 898347
4 years ago
4 years ago

People

(Reporter: nsm, Assigned: nsm)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

Created attachment 789345 [details] [diff] [review]
Re-enable Binary Data

Except let's do it with fuzzing this time.

:decoder, :gkw, thanks!
Attachment #789345 - Flags: review?(nmatsakis)
Attachment #789345 - Flags: feedback?(gary)
Attachment #789345 - Flags: feedback?(choller)
Depends on: 904755
Depends on: 904780
Comment on attachment 789345 [details] [diff] [review]
Re-enable Binary Data

new StructType({0: 0});

Assertion failure: JSID_IS_STRING(iden), at ../jsapi.h:1240

===

new ArrayType(uint8, -null);

Assertion failure: isInt32(), at ./dist/include/js/Value.h:1093

===

gczeal(8, 1);
new StructType(RegExp());

Assertion failure: fieldList, at /srv/repos/mozilla-central/js/src/builtin/BinaryData.cpp:1722
Attachment #789345 - Flags: feedback?(choller) → feedback-
Comment on attachment 789345 [details] [diff] [review]
Re-enable Binary Data

Clearing feedback? flag until outstanding bugs are fixed.
Attachment #789345 - Flags: feedback?(gary)
Created attachment 789854 [details] [diff] [review]
Fuzzer fixes

These should fix comment 1 bugs.
Flags: needinfo?(gary)
Created attachment 789859 [details] [diff] [review]
Re-enable binary data, with several fixes.
Attachment #789345 - Attachment is obsolete: true
Attachment #789345 - Flags: review?(nmatsakis)
Attachment #789854 - Attachment is obsolete: true
Comment on attachment 789859 [details] [diff] [review]
Re-enable binary data, with several fixes.

x = [];
Object.defineProperty(x, 2, {})
Array.prototype.map.call(x, Data.prototype.update)

Crashes js debug 64-bit deterministic threadsafe shell [@ js::EncapsulatedPtr]
Attachment #789859 - Flags: feedback-
Created attachment 789924 [details]
stack for testcase in comment 5
Flags: needinfo?(gary)
Created attachment 789981 [details] [diff] [review]
Re-enable binary data, with several fixes.
Attachment #789859 - Attachment is obsolete: true
Comment on attachment 789981 [details] [diff] [review]
Re-enable binary data, with several fixes.

Haven't hit more problems so far :)
Attachment #789981 - Flags: feedback+
Comment on attachment 789981 [details] [diff] [review]
Re-enable binary data, with several fixes.

No major problems found so far either.
Attachment #789981 - Flags: feedback+
Blocks: 898347
Was fixed in https://hg.mozilla.org/mozilla-central/rev/10f121af2f56
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 898347
You need to log in before you can comment on or make changes to this bug.