904358 - [cleanup][fireplace] Re-organize hearth/templates/ and smokealarm/tests/ directories

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Code Quality, defect, P4)

Description

[Matt Basta [:basta]]

The templates directory is a real crapshoot right now. Most of the stuff in there was built well before we'd even developed the builder. Stuff that needs doing:

- Change files to have names that match their views (search/main.html -> search.html)
- Move utility templates to a directory (deprecated.html, obsolete.html)
- Group similar templates in directories (cat dropdown templates to their own directory)
- The "user" directory doesn't make sense; figure out how to combine it with "settings"
- "detail" -> "app"?

The smokealarm tests also need to be re-organized:

- Classify into user flow/UI directories (tests/flow/, tests/ui/). E.g.: cat dropdown tests to tests/ui/cat_dropdown/
- Organize flow tests by view (tests/flow/search/, tests/flow/detail_page/, etc.)
- Organize UI tests by component (tests/ui/cat_dropdown/, tests/ui/tabs/, etc.)
- Rename flow test files and directories to match view names where possible
- Make test names less redundant (tests/app/app_from_abuse.js -> tests/app/from_abuse.js)

https://github.com/mozilla/fireplace

Comment 1

[Mark Striemer [:mstriemer]]

The app structure has changed significantly. This doesn't seem relevant anymore.