904443 - Search result summary beginning is missing

Status: RESOLVED FIXED

(support.mozilla.org :: Search, defect, P1)

Description

[Scoobidiver (away)]

Since the landing of bug 900869, the search result summary beginning is missing.

See https://support.mozilla.org/en-US/search?product=firefox&q=firefox or https://support.mozilla.org/en-US/search?product=firefox&q=load

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Yep, we used to show the full search summmary before the highlighting change for l10n.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

In a PR: https://github.com/mozilla/kitsune/pull/1560

Landed in master in: https://github.com/mozilla/kitsune/commit/0d3abb4

Pushed to prod just now.

Comment 3

[Scoobidiver (away)]

Thanks for the quick fix.
Verified with the two examples of comment 0 for article and question results.
For forum threads, results display the full thread. It should have been restricted to the first post. See https://support.mozilla.org/en-US/search?q=article&forum=3&a=1&w=4

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Rrrr... I hate this search code so much.

I'll have to look into why it's not working for the contributor forum searches.

Reopening for that.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

So, the problem here is that until recently, we weren't doing any highlights/excerpts for contributor forum search results. Contributor forums are different than the other two groups, so we've got a few options:

1. don't show any excerpts at all -- this returns us to where we were a month ago

2. show only the first post in a contributor forum thread highlighted

3. rewrite the search view so I can do the highlighting stuff separately since there's no way anyone can do a search that includes contributor forum results and any other mapping type


Of those, I can do the first one under the auspices of this bug since it's an easy fix. That returns us to where things were at a month ago. For the other two options, we'd need to spin off a new bug because they're essentially new work and both are non-trivial.

Since the number of contributor forum searches is pretty low (per Ibai's data a few months ago), I think option 2 is probably the way to go. It's like 2 points worth of work.

Alternatively, since no one does contributor forum searches, maybe it's fine to leave it as it is now?

Kadir: Any preferences?

Comment 6

[Kadir Topal [:atopal]]

Let's go with 1. Volume of threads and number of searches are far too low to justify spending much time on this, but showing whole posts makes it hard to skim search results. Thanks, Will!

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

I decided option 1 sucks. So I spent some time looking at the code and figured out another way to do it.

In a PR: https://github.com/mozilla/kitsune/pull/1569

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master: https://github.com/mozilla/kitsune/commit/40a3e19

Pushed to prod now.

Marking this as FIXED.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

Changing this to be a 1 point bug since I ended up spending more time on it than I originally expected.