Open Bug 904503 Opened 11 years ago Updated 2 years ago

Pointer-lock feature confirmation changes keyboard focus and breaks keyboard arrow keys controls

Categories

(Core :: DOM: Events, defect)

23 Branch
x86
All
defect

Tracking

()

ASSIGNED

People

(Reporter: dave, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Whiteboard: [games:p?])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1500.95 Safari/537.36

Steps to reproduce:

Go to http://apps.playcanvas.com/playcanvas/tutorials/fps_character_controller

Click on the screen and give permission for pointer lock to take your cursor.




Actual results:

You can move the viewpoint, but the keyboard controls (arrow keys or WASD) do not work.



Expected results:

Keyboard focus should remain with the game and keyboard controls should work (as in Chrome)

Note, if you press ESC when the permission dialog is up and then click again, keyboard control works as it should.
Could you verify if you see the problem on Firefox beta?
http://www.mozilla.org/it/firefox/beta/

Do you see this problem each time you use that tutorial?
Flags: needinfo?(dave)
Note that this problem is also exhibited here:

http://www.html5rocks.com/en/tutorials/pointerlock/intro/

I just mention it in case it's useful to have another test case.  Scroll down to the 'putting it all together' example.  Notice how in Firefox the arrow keys no longer work after clicking on the 'Hide Pointer' modal dialog.  This happens in Release, Aurora and Nightly (on my Win7 machine).
(In reply to Will Eastcott from comment #2)
>  Notice how in Firefox the
> arrow keys no longer work after clicking on the 'Hide Pointer' modal dialog.
> This happens in Release, Aurora and Nightly (on my Win7 machine).


Reproduced with latest Nightly
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130822030204
Component: Untriaged → DOM: Events
OS: Mac OS X → All
Product: Firefox → Core
Summary: Pointer-lock feature confirmation changes keyboard focus → Pointer-lock feature confirmation changes keyboard focus and breaks keyboard arrow keys controls
Olli, any chance you can take a look at this, please?  Thanks!
Assignee: nobody → bugs
Whiteboard: [games:p1]
Hi all. Just curious if there's been any progress with this issue over the last couple of weeks. Thanks in advance.
I haven't had time to look at this. And don't expect to have any time for this before October.
Flags: needinfo?(dave)
Attached file frame.html
This is a simple test case.

To reproduce:

Load HTML file in Firefox.
Click the red square
Typing on keyboard will add text to the page
Click the lock button
In the pop-up select "Always hide pointer"
Press escape to return pointer.
Click red square.
Click lock button
Click again to clear pop up.
Keyboard no longer adds text to page.
Blocks: gecko-games
Any progress with this bug? Sorry to chase, but PlayCanvas users are still getting badly burned by it.
(In reply to Dave Evans from comment #7)
> Created attachment 824611 [details]
> frame.html
> 
> This is a simple test case.
> 
> To reproduce:
> 
> Load HTML file in Firefox.
> Click the red square
> Typing on keyboard will add text to the page
> Click the lock button
> In the pop-up select "Always hide pointer"
> Press escape to return pointer.
> Click red square.
> Click lock button
> Click again to clear pop up.
> Keyboard no longer adds text to page.

Works fine here if "Click again to clear pop up" means click again the red square.
(In reply to Olli Pettay [:smaug] from comment #9)
> (In reply to Dave Evans from comment #7)
> > Created attachment 824611 [details]
> > frame.html
> > 
> > This is a simple test case.
> > 
> > To reproduce:
> > 
> > Load HTML file in Firefox.
> > Click the red square
> > Typing on keyboard will add text to the page
> > Click the lock button
> > In the pop-up select "Always hide pointer"
> > Press escape to return pointer.
> > Click red square.
> > Click lock button
> > Click again to clear pop up.
> > Keyboard no longer adds text to page.
> 
> Works fine here if "Click again to clear pop up" means click again the red
> square.

On my machine, in FF 25.0.1 on OS X 10.8.5, following the above steps means the keyboard doesn't add text to the page.

I _can_ get focus to remain with the red square if I click the X in the pop-up, but clicking anywhere else leaves it without keyboard focus.
Do we have a status on this bug.  It's been a while and really needs to get fixed.
(In reply to Dave Evans from comment #10)
> (In reply to Olli Pettay [:smaug] from comment #9)
> > (In reply to Dave Evans from comment #7)
> > > Created attachment 824611 [details]
> > > frame.html
> > > 
> > > This is a simple test case.
> > > 
> > > To reproduce:
> > > 
> > > Load HTML file in Firefox.
> > > Click the red square
> > > Typing on keyboard will add text to the page
> > > Click the lock button
> > > In the pop-up select "Always hide pointer"
> > > Press escape to return pointer.
> > > Click red square.
> > > Click lock button
> > > Click again to clear pop up.
> > > Keyboard no longer adds text to page.
> > 
> > Works fine here if "Click again to clear pop up" means click again the red
> > square.
> 
> On my machine, in FF 25.0.1 on OS X 10.8.5, following the above steps means
> the keyboard doesn't add text to the page.
> 
> I _can_ get focus to remain with the red square if I click the X in the
> pop-up, but clicking anywhere else leaves it without keyboard focus.

I can't reproduce the bug either on Nightly with OS X 10.9.
The problem appears to be fixed on the Mac.  The bug still seems to be there on Windows (7) in both Stable and Nightly.
Olli, any chance you could test this on Windows please?
Flags: needinfo?(bugs)
I have the same issue. Thanks in advance for having this fixed in near future.
I have just tested in FF 28.0 (Stable) on Windows 7 and the bug no longer seems to be in evidence. Thank you very much for finally getting this resolved. PlayCanvas FPS experiences now work great in Firefox again. I'm happy for this to be closed.
Dave, can you still reproduce this?
Flags: needinfo?(bugs) → needinfo?(dave)
I confirm this is fixed on OS X FF 30.0

Thanks

(In reply to Olli Pettay [:smaug] from comment #17)
> Dave, can you still reproduce this?
Flags: needinfo?(dave)
Works in OSX.
Nightly Build: 42.0a1 (2015-07-31)
Whiteboard: [games:p1] → [games:p?]
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: