904515 - [Contact] Matching is not working when phone number is saved with prefix

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[isabelrios]

Unagi device master 08/13 build:
Gecko-2fb3fd7
Gaia-8fd21ce
ref ril

STR
1. Create a new contact with Name, Last Name and Phone Number, i.e: Contact 123456789
2. Tap on Done
3. Create a second contact with Name, Last Name and same Phone Number but without prefix: [phone]
4. Tap on Done

EXPECTED
After tapping on Done when the second contact is created, the Duplicates found screen should be shown with the option to Merge both contacts as the phone number is the same

ACTUAL
The Duplicates found screen is not shown. The second contact is created normally.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

koi+ as it links to koi-comms bug

Comment 2

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Since the phone number matching depends on the search implementation from contacts API, there is bug 860806 which already tracks searching internationalized numbers.

The patch from there might solve this issue without needing any other changes.

Comment 3

[Matěj Cepl]

Isn't this duplicate of bug 875542 ?

Comment 4

[Julien Wajsberg [:julienw]]

Matej: nope, the search inside the Contacts app is done using a different mean.

Isabel, could you please test this again with a recent build ?

Comment 5

[isabelrios]

Hi Julien,

With today (09/13) build, 
Gecko-ec0b45d
Gaia-0df2b51

The bug can be reproduced.

Comment 6

[Jose Manuel Cantera]

Isabel,

I cannot reproduce this. Please could you try it with a real phone number and not with dummy numbers? 

For instance, in Spain +34 xxxx, France +33 xxx etc. 

thanks

Comment 7

[isabelrios]

There are still some problems:

Having a contact in the contact list with +34 xxxxxxxxx and importing from SIM the same contact with xxxxxxxxx, will merge but in contact's details two entries are created for phone numbers, one for each number, with and without prefix.

Having a contact in the contact list with xxxxxxxxx and importing from SIM the same contact with +34 xxxxxxxxx, will not merge and two contacts appear in the contact list.

Also, if there is a contact in the contact list with +34 xxxxxxxxx or xxxxxxxxx, and a new contact is created with 0034 xxxxxxxxx, no duplicates are found.

All tests done with valid numbers.

Comment 8

[Noemí Freire (:noemi)]

Hi

Tested with 10/02 v1.2 build:
Gecko-f0e33a4
Gaia-7447624

Having 555555555 in the contact list and adding [phone] -> duplicates found
Having 666666666 in the contact list and adding [phone] -> duplicates found
Having 619248361 in the contact list and adding [phone] -> duplicates found
Having 444444444 in the contact list and adding [phone] -> duplicates not found
Having 456787878 in the contact list and adding [phone] -> duplicates not found


In addition to the last issue in comment 7,no duplicates are found when trying to add 0034 XXXXXXXXX in all scenarios above.

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys, "quick" update about this issue ;-)

Testing using Gecko-ebd615f and Gaia-master (from some minutes ago), the cases Noemí mentions (kind of) work. I say kind of since:
  1. Having a contact with phone number 444444444 (which was a case Noemí mentioned in her last comment) and name: "N1"...
  2. Adding a new contact with phone number [phone] and name "N2"-> Detects the presence of a duplicate (the one from 1). Do not merge them.
  3. Adding an additional contact with phone number 0034444444444 and name "N3" -> Detects the presence of 2 duplicates (the ones from 1 and 2). The problem here is that the matched phone number is not properly highlighted (I'll upload a screenshot in a sec.). On the same hand, when showing the matching contact details, the phone number is not properly highlighted either (new attachment on the go).

As a side note, this problem reproduces when the original contact' phone number has a national prefix on it. This is, finding matching contacts for [phone] or for 0034444444444 causes the previous mentioned misbehavior, whereas when finding duplicate contacts for the contact with phone number 444444444 works as expected and the matching phone numbers are properly shown and highlighted.

Investigating the source of this issue. I'll keep you posted.

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: device-2013-10-07-122950.png

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: device-2013-10-07-123002.png

Comment 12

[isabelrios]

FYi, two bugs created for covering the two issues mentioned in comment 7:

Bug 924064
Having a contact in the contact list with +34 xxxxxxxxx and importing from SIM the same contact with xxxxxxxxx, will merge but in contact's details two entries are created for phone numbers, one for each number, with and without prefix.

Bug 924066
Having a contact in the contact list with xxxxxxxxx and importing from SIM the same contact with +34 xxxxxxxxx, will not merge and two contacts appear in the contact list.

Comment 13

[Germán Toro del Valle (:gtorodelvalle)]

Geez! This is getting weirder ;-999

comment 8 is the observed behavior in case the device has a physical SIM inserted, whereas comment 9 to comment 11 is the observed behavior when the device has no physical SIM inserted :-O

In this last case (no SIM inserted), the highlighting problem mentioned in comment 9 is due to the way the numbers are sanitized and compared in contacts_matcher.js (https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/contacts_matcher.js#L89) In case of numbers with national prefixes, this comparison is not right since "+34..." is not equal to "0034...". We should be using variants and simple_phone_matcher.js (https://github.com/mozilla-b2g/gaia/blob/master/shared/js/simple_phone_matcher.js) for this.

I'll solve the second issue (no physical SIM inserted) and then move to the first one so the highlighting issue should also be solved ;-)

Comment 14

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: PR 1 - highlighting part

Comment 15

[Jose Manuel Cantera]

Patch for Highlighting and Phone Variants landed on master:

https://github.com/mozilla-b2g/gaia/commit/e034881d8750f9a547c116e0812067784f8f65f1

Comment 16

[Germán Toro del Valle (:gtorodelvalle)]

Hi! once bug 924378 has been solved, this bug is also fixed ;-) Thanks!

Comment 17

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted e034881d8750f9a547c116e0812067784f8f65f1 to:
v1.2: bc59ef0640ba883bf9844fdd0be722dad43e193d

Comment 18

[isabelrios]

Verified on 10/25 v1.2 build:
Gecko-9150851
Gaia-606517c