Closed Bug 904579 Opened 11 years ago Closed 11 years ago

eliminate smart-pointer-related static constructors in widget/android/

Categories

(Core Graveyard :: Widget: Android, defect)

Product:
Core Graveyard
Component:
Widget: Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla26

People

(Reporter: froydnj, Unassigned)

Details

Attachments

(2 files)

don't use nsCOMPtr for concrete classes in android's nsWindow.cpp
2.03 KB, patch
blassey
: review+
Details | Diff | Splinter Review
convert some nsRefPtrs to StaticRefPtrs in widget/android/
4.33 KB, patch
blassey
: review+
Details | Diff | Splinter Review 
      No description provided.
We should be using nsRefPtrs...and since this is a static variable, we can use
StaticRefPtr.
Attachment #789547 - Flags: review?(blassey.bugs)
These don't require static constructors.  They do have a disadvantage, insofar
as they are never freed by the existing code or magically through static destructors.
But I figure on Android, this probably doesn't matter a whole lot (we were never
running the static destructors anyway...)
Attachment #789548 - Flags: review?(blassey.bugs)
Attachment #789547 - Flags: review?(blassey.bugs) → review+
Attachment #789548 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c19762807e32
https://hg.mozilla.org/mozilla-central/rev/5f8ed64eb3ca
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: