Closed Bug 904579 Opened 7 years ago Closed 7 years ago

eliminate smart-pointer-related static constructors in widget/android/

Categories

(Core :: Widget: Android, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: froydnj, Unassigned)

Details

Attachments

(2 files)

No description provided.
We should be using nsRefPtrs...and since this is a static variable, we can use
StaticRefPtr.
Attachment #789547 - Flags: review?(blassey.bugs)
These don't require static constructors.  They do have a disadvantage, insofar
as they are never freed by the existing code or magically through static destructors.
But I figure on Android, this probably doesn't matter a whole lot (we were never
running the static destructors anyway...)
Attachment #789548 - Flags: review?(blassey.bugs)
Attachment #789547 - Flags: review?(blassey.bugs) → review+
Attachment #789548 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c19762807e32
https://hg.mozilla.org/mozilla-central/rev/5f8ed64eb3ca
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.