Closed Bug 904613 Opened 12 years ago Closed 12 years ago

Published makes with detail bar hidden 404

Categories

(Webmaker Graveyard :: Make Valet, defect)

Product:
Webmaker Graveyard
Component:
Make Valet
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: jon, Assigned: jon)

References

(
URL
)

Details

No description provided.
When you hide the details bar of a make via ?details=hidden, the make-valet 404s that page. When you remove the query string, it works fine. It turns out that the make-valet is searching for the make with query string, so that won't work.
Summary: Published makes with deta → Published makes with detail bar hidden 404
Commit pushed to master at https://github.com/mozilla/make-valet https://github.com/mozilla/make-valet/commit/33af4f6791449b0e42eac17084762e3e2039d17a Fix bug 904613 - Don't search for makes with query string. r=thecount
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified that https://scott.makes.org/thimble/tutorial?details=hidden works now
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.