904625 - Wrong error message displayed when making a call in airplane mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Florin Strugariu [:Bebe]]

STR:
1. Activate airplane mode
2. Try to make a call
3. Verify the error message

Expected:
3. The error message should be:
"Airplane mode activated"

Actual:
3. The error message is:
"No network connection"

Screenshot:
http://imgur.com/FI3QjZP

This is reproducible on:

Gecko  http://hg.mozilla.org/mozilla-central/rev/8c240c67f76c
Gaia  b527d7406b4eed3bacdee78597bb4ff21bf9f7d0
BuildID 20130813040222
Version 26.0a1

Comment 1

[David Scravaglieri [:scravag]]

We plus it as it is a regression

Comment 2

[:gerard-majax]

Reproducing in Inari :)

Comment 3

[:gerard-majax]

In telephony_helper.js, we have a check against conn.voice.network that explains the current behavior. Removing this would allow to go further in the code path, but when placing a call in this state, we do a dialEmergency() and I get no error coming back from Gecko when calling something else than 112.

Comment 4

[:gerard-majax]

Bug 909638 adds the needed bits for proper error to get back to us.

Comment 5

[:gerard-majax]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12115

Pointer to Github pull-request

Comment 6

[:gerard-majax]

Comment on attachment 802933 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12115

Please find attached a link to the github pull request that addresses the issue.

Comment 7

[Etienne Segonzac (:etienne)]

Comment on attachment 802933 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12115

sweet and simple, thanks!

Comment 8

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/9025d9103e2bb344bf99a986e08ae75732dcd675

Comment 10

[Kai-Chih Hu [:khu]]

Looks like this was resolved by Alex Lissy.