[OS.File] Port osfile_{win, unix}_allthreads.jsm to worker module loader

RESOLVED FIXED in mozilla27

Status

()

Toolkit
OS.File
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Yoric, Assigned: Yoric)

Tracking

(Blocks: 2 bugs, {dev-doc-needed})

unspecified
mozilla27
dev-doc-needed
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Async])

Attachments

(1 attachment, 10 obsolete attachments)

142.13 KB, patch
Yoric
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
Created attachment 790080 [details] [diff] [review]
1. Porting osfile_{win, unix}_allthreads.jsm to require()
Assignee: nobody → dteller
Attachment #790080 - Flags: review?(nfroyd)
Created attachment 790083 [details] [diff] [review]
1bis. Porting osfile_{win, unix}_allthreads.jsm to require() - ignoring whitespace - DO NOT LAND
Attachment #790083 - Flags: feedback?(nfroyd)
Created attachment 790084 [details] [diff] [review]
2. Propagating to client modules
Attachment #790084 - Flags: review?(nfroyd)
Created attachment 790085 [details] [diff] [review]
3. Changes to the test suite
Attachment #790085 - Flags: review?(nfroyd)
Attachment #790085 - Attachment is patch: true
Created attachment 790086 [details] [diff] [review]
4. Taking the opportunity to improve error message reporting
Attachment #790086 - Flags: review?(nfroyd)
Attachment #790083 - Flags: feedback?(nfroyd) → feedback+
Attachment #790080 - Flags: review?(nfroyd) → review+
Attachment #790084 - Flags: review?(nfroyd) → review+
Attachment #790085 - Flags: review?(nfroyd) → review+
Attachment #790086 - Flags: review?(nfroyd) → review+
Depends on: 918364
Created attachment 807671 [details] [diff] [review]
Merged patch

Same patch, rebased and merged.
Attachment #790080 - Attachment is obsolete: true
Attachment #790083 - Attachment is obsolete: true
Attachment #790084 - Attachment is obsolete: true
Attachment #790085 - Attachment is obsolete: true
Attachment #790086 - Attachment is obsolete: true
Attachment #807671 - Flags: review+
The freezing of object |OS.File| seems to conflict with test_DeferredSave.js
Same patch, minus freeze:
Try: https://tbpl.mozilla.org/?tree=Try&rev=cdb56544ad86
Created attachment 812184 [details] [diff] [review]
Merged patch, v2

Fixed a few minor errors here and there.
Try: https://tbpl.mozilla.org/?tree=Try&rev=b409cc3a7cad
Attachment #807671 - Attachment is obsolete: true
Attachment #812184 - Flags: review+
Created attachment 812701 [details] [diff] [review]
Merged patch, v3

More unbitrotting.
Try: https://tbpl.mozilla.org/?tree=Try&rev=c9569b4108d2
Attachment #812184 - Attachment is obsolete: true
Attachment #812701 - Flags: review+
Keywords: checkin-needed
Keywords: dev-doc-needed
https://hg.mozilla.org/integration/fx-team/rev/9f16839e91c3
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [Async] → [Async][fixed-in-fx-team]
Backed out for Gaia UI test failures.
https://hg.mozilla.org/integration/fx-team/rev/a5f4a9a55526

https://tbpl.mozilla.org/php/getParsedLog.php?id=28623313&tree=Fx-Team
Flags: in-testsuite+
Whiteboard: [Async][fixed-in-fx-team] → [Async]
And by Gaia UI tests, I meant all B2G tests.
Oh, looks like I had a |let OS = | that should have been a |this.OS = | due to the different module rules on B2G.

Try: https://tbpl.mozilla.org/?tree=Try&rev=5083c2a75490
Created attachment 814515 [details] [diff] [review]
Merged patch, v4
Attachment #812701 - Attachment is obsolete: true
Attachment #814515 - Flags: review+
Keywords: checkin-needed
Bitrotted. Please rebase :)
Keywords: checkin-needed
Created attachment 817121 [details] [diff] [review]
Merged patch, v5

Same patch, unbitrotten.
Try: https://tbpl.mozilla.org/?tree=Try&rev=ca8dff5b84b1
Attachment #814515 - Attachment is obsolete: true
Attachment #817121 - Flags: review+
Keywords: checkin-needed
Thanks :)

https://hg.mozilla.org/integration/fx-team/rev/03d629375717
Keywords: checkin-needed
Whiteboard: [Async] → [Async][fixed-in-fx-team]
Backed out for Windows test bustage (not visible in the last Try push because it was completely busted).
https://hg.mozilla.org/integration/fx-team/rev/4fd49e8f5577
Whiteboard: [Async][fixed-in-fx-team] → [Async]
Created attachment 817453 [details] [diff] [review]
Merged patch, v6

Added bracket lost in unbitrotting.
Try: https://tbpl.mozilla.org/?tree=Try&rev=9c841d14cc3d
Attachment #817121 - Attachment is obsolete: true
Attachment #817453 - Flags: review+
Oh, great, another busted m-c.
Same patch, after repull: https://tbpl.mozilla.org/?tree=Try&rev=915a07ad1d2c
That might just possibly work better if I remove some Try-specific debugging c++ code that doesn't build anymore.
Try: https://tbpl.mozilla.org/?tree=Try&rev=b73fb41bbff1
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/aa160d21eb25
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [Async] → [Async][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/aa160d21eb25
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [Async][fixed-in-fx-team] → [Async]
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.