Closed Bug 904652 Opened 7 years ago Closed 6 years ago

[OS.File] Port osfile_{win, unix}_allthreads.jsm to worker module loader

Categories

(Toolkit :: OS.File, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: Yoric, Assigned: Yoric)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-needed, Whiteboard: [Async])

Attachments

(1 file, 10 obsolete files)

142.13 KB, patch
Yoric
: review+
Details | Diff | Splinter Review
No description provided.
Assignee: nobody → dteller
Attachment #790080 - Flags: review?(nfroyd)
Attached patch 2. Propagating to client modules (obsolete) — Splinter Review
Attachment #790084 - Flags: review?(nfroyd)
Attached patch 3. Changes to the test suite (obsolete) — Splinter Review
Attachment #790085 - Flags: review?(nfroyd)
Attachment #790085 - Attachment is patch: true
Attachment #790083 - Flags: feedback?(nfroyd) → feedback+
Attachment #790080 - Flags: review?(nfroyd) → review+
Attachment #790084 - Flags: review?(nfroyd) → review+
Attachment #790085 - Flags: review?(nfroyd) → review+
Attachment #790086 - Flags: review?(nfroyd) → review+
Attached patch Merged patch (obsolete) — Splinter Review
Same patch, rebased and merged.
Attachment #790080 - Attachment is obsolete: true
Attachment #790083 - Attachment is obsolete: true
Attachment #790084 - Attachment is obsolete: true
Attachment #790085 - Attachment is obsolete: true
Attachment #790086 - Attachment is obsolete: true
Attachment #807671 - Flags: review+
The freezing of object |OS.File| seems to conflict with test_DeferredSave.js
Same patch, minus freeze:
Try: https://tbpl.mozilla.org/?tree=Try&rev=cdb56544ad86
Attached patch Merged patch, v2 (obsolete) — Splinter Review
Fixed a few minor errors here and there.
Try: https://tbpl.mozilla.org/?tree=Try&rev=b409cc3a7cad
Attachment #807671 - Attachment is obsolete: true
Attachment #812184 - Flags: review+
Attached patch Merged patch, v3 (obsolete) — Splinter Review
More unbitrotting.
Try: https://tbpl.mozilla.org/?tree=Try&rev=c9569b4108d2
Attachment #812184 - Attachment is obsolete: true
Attachment #812701 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/9f16839e91c3
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [Async] → [Async][fixed-in-fx-team]
Backed out for Gaia UI test failures.
https://hg.mozilla.org/integration/fx-team/rev/a5f4a9a55526

https://tbpl.mozilla.org/php/getParsedLog.php?id=28623313&tree=Fx-Team
Flags: in-testsuite+
Whiteboard: [Async][fixed-in-fx-team] → [Async]
And by Gaia UI tests, I meant all B2G tests.
Oh, looks like I had a |let OS = | that should have been a |this.OS = | due to the different module rules on B2G.

Try: https://tbpl.mozilla.org/?tree=Try&rev=5083c2a75490
Attached patch Merged patch, v4 (obsolete) — Splinter Review
Attachment #812701 - Attachment is obsolete: true
Attachment #814515 - Flags: review+
Bitrotted. Please rebase :)
Keywords: checkin-needed
Attached patch Merged patch, v5 (obsolete) — Splinter Review
Same patch, unbitrotten.
Try: https://tbpl.mozilla.org/?tree=Try&rev=ca8dff5b84b1
Attachment #814515 - Attachment is obsolete: true
Attachment #817121 - Flags: review+
Backed out for Windows test bustage (not visible in the last Try push because it was completely busted).
https://hg.mozilla.org/integration/fx-team/rev/4fd49e8f5577
Whiteboard: [Async][fixed-in-fx-team] → [Async]
Attached patch Merged patch, v6Splinter Review
Added bracket lost in unbitrotting.
Try: https://tbpl.mozilla.org/?tree=Try&rev=9c841d14cc3d
Attachment #817121 - Attachment is obsolete: true
Attachment #817453 - Flags: review+
Oh, great, another busted m-c.
Same patch, after repull: https://tbpl.mozilla.org/?tree=Try&rev=915a07ad1d2c
That might just possibly work better if I remove some Try-specific debugging c++ code that doesn't build anymore.
Try: https://tbpl.mozilla.org/?tree=Try&rev=b73fb41bbff1
https://hg.mozilla.org/integration/fx-team/rev/aa160d21eb25
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [Async] → [Async][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/aa160d21eb25
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Async][fixed-in-fx-team] → [Async]
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.