Closed
Bug 904664
Opened 12 years ago
Closed 12 years ago
FM Radio: typo in const name
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: hub, Unassigned)
Details
Attachments
(1 file)
|
1.71 KB,
patch
|
dhylands
:
review+
|
Details | Diff | Splinter Review |
In FMRadio.cpp
there is a constant named RADIO_DIABLED_EVENT_NAME while it should be RADIO_DISABLED_EVENT_NAME
It is cosmetic and doesn't break the functionality, nor the API.
|
Reporter | |
Comment 1•12 years ago
|
||
|
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 789643 [details] [diff] [review]
Fix typo in const name. r=
(using suggested to reviewer to request review)
Attachment #789643 -
Flags: review?(dhylands)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 789643 [details] [diff] [review]
Fix typo in const name. r=
Review of attachment 789643 [details] [diff] [review]:
-----------------------------------------------------------------
r=me with nit addressed
::: dom/fm/FMRadio.cpp
@@ +24,5 @@
> // If the pref is true, the antanna will be always available.
> #define DOM_FM_ANTENNA_INTERNAL_PREF "dom.fm.antenna.internal"
>
> #define RADIO_SEEK_COMPLETE_EVENT_NAME NS_LITERAL_STRING("seekcomplete")
> +#define RADIO_DISABLED_EVENT_NAME NS_LITERAL_STRING("disabled")
nit: fix alignment of NS_LITERAL_STRING
Attachment #789643 -
Flags: review?(dhylands) → review+
|
|
Reporter | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•